From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
aliguori@us.ibm.com, quintela@redhat.com, jan.kiszka@siemens.com,
mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed
Date: Mon, 24 Oct 2011 14:54:59 +1030 [thread overview]
Message-ID: <87ty6z10f8.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111022054311.21798.3340.stgit@dhcp-8-146.nay.redhat.com>
On Sat, 22 Oct 2011 13:43:11 +0800, Jason Wang <jasowang@redhat.com> wrote:
> This make let virtio-net driver can send gratituous packet by a new
> config bit - VIRTIO_NET_S_ANNOUNCE in each config update
> interrupt. When this bit is set by backend, the driver would schedule
> a workqueue to send gratituous packet through NETDEV_NOTIFY_PEERS.
>
> This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
This seems like a huge layering violation. Imagine this in real
hardware, for example.
There may be a good reason why virtual devices might want this kind of
reconfiguration cheat, which is unnecessary for normal machines, but
it'd have to be spelled out clearly in the spec to justify it...
Cheers,
Rusty.
WARNING: multiple messages have this Message-ID (diff)
From: Rusty Russell <rusty@rustcorp.com.au>
To: Jason Wang <jasowang@redhat.com>,
aliguori@us.ibm.com, quintela@redhat.com, jan.kiszka@siemens.com,
mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [Qemu-devel] [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed
Date: Mon, 24 Oct 2011 14:54:59 +1030 [thread overview]
Message-ID: <87ty6z10f8.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20111022054311.21798.3340.stgit@dhcp-8-146.nay.redhat.com>
On Sat, 22 Oct 2011 13:43:11 +0800, Jason Wang <jasowang@redhat.com> wrote:
> This make let virtio-net driver can send gratituous packet by a new
> config bit - VIRTIO_NET_S_ANNOUNCE in each config update
> interrupt. When this bit is set by backend, the driver would schedule
> a workqueue to send gratituous packet through NETDEV_NOTIFY_PEERS.
>
> This feature is negotiated through bit VIRTIO_NET_F_GUEST_ANNOUNCE.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
This seems like a huge layering violation. Imagine this in real
hardware, for example.
There may be a good reason why virtual devices might want this kind of
reconfiguration cheat, which is unnecessary for normal machines, but
it'd have to be spelled out clearly in the spec to justify it...
Cheers,
Rusty.
next prev parent reply other threads:[~2011-10-24 4:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-22 5:43 [RFC v2 PATCH 5/4 PATCH] virtio-net: send gratuitous packet when needed Jason Wang
2011-10-22 5:43 ` [Qemu-devel] " Jason Wang
2011-10-24 4:24 ` Rusty Russell [this message]
2011-10-24 4:24 ` Rusty Russell
2011-10-24 5:25 ` Michael S. Tsirkin
2011-10-24 5:25 ` [Qemu-devel] " Michael S. Tsirkin
2011-10-24 9:11 ` Ben Hutchings
2011-10-24 9:11 ` Ben Hutchings
2011-10-25 2:50 ` Jason Wang
2011-10-25 2:50 ` [Qemu-devel] " Jason Wang
2011-10-25 15:41 ` Michael S. Tsirkin
2011-10-25 15:41 ` [Qemu-devel] " Michael S. Tsirkin
2011-10-26 4:49 ` Jason Wang
2011-10-26 4:49 ` [Qemu-devel] " Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty6z10f8.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.