* [patch 2/2]block: add missed trace_block_plug
@ 2011-09-28 3:11 Shaohua Li
2011-09-28 8:49 ` Namhyung Kim
0 siblings, 1 reply; 2+ messages in thread
From: Shaohua Li @ 2011-09-28 3:11 UTC (permalink / raw)
To: Jens Axboe; +Cc: lkml
After flush plug list, the list has no request, so we need
add a trace_block_plug.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
block/blk-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Index: linux/block/blk-core.c
===================================================================
--- linux.orig/block/blk-core.c 2011-09-28 11:05:22.000000000 +0800
+++ linux/block/blk-core.c 2011-09-28 11:05:42.000000000 +0800
@@ -1307,8 +1307,10 @@ get_rq:
if (__rq->q != q)
plug->should_sort = 1;
}
- if (request_count >= BLK_MAX_REQUEST_COUNT)
+ if (request_count >= BLK_MAX_REQUEST_COUNT) {
blk_flush_plug_list(plug, false);
+ trace_block_plug(q);
+ }
}
list_add_tail(&req->queuelist, &plug->list);
drive_stat_acct(req, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2/2]block: add missed trace_block_plug
2011-09-28 3:11 [patch 2/2]block: add missed trace_block_plug Shaohua Li
@ 2011-09-28 8:49 ` Namhyung Kim
0 siblings, 0 replies; 2+ messages in thread
From: Namhyung Kim @ 2011-09-28 8:49 UTC (permalink / raw)
To: Shaohua Li; +Cc: Jens Axboe, lkml
Shaohua Li <shaohua.li@intel.com> writes:
> After flush plug list, the list has no request, so we need
> add a trace_block_plug.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Reviewed-by: Namhyung Kim <namhyung@gmail.com>
>
> ---
> block/blk-core.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> Index: linux/block/blk-core.c
> ===================================================================
> --- linux.orig/block/blk-core.c 2011-09-28 11:05:22.000000000 +0800
> +++ linux/block/blk-core.c 2011-09-28 11:05:42.000000000 +0800
> @@ -1307,8 +1307,10 @@ get_rq:
> if (__rq->q != q)
> plug->should_sort = 1;
> }
> - if (request_count >= BLK_MAX_REQUEST_COUNT)
> + if (request_count >= BLK_MAX_REQUEST_COUNT) {
> blk_flush_plug_list(plug, false);
> + trace_block_plug(q);
> + }
> }
> list_add_tail(&req->queuelist, &plug->list);
> drive_stat_acct(req, 1);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-28 8:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-28 3:11 [patch 2/2]block: add missed trace_block_plug Shaohua Li
2011-09-28 8:49 ` Namhyung Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.