From: Kevin Hilman <khilman@ti.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/5] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code
Date: Tue, 05 Jul 2011 17:51:13 +0000 [thread overview]
Message-ID: <87tyb0sjji.fsf@ti.com> (raw)
In-Reply-To: <1309788705-22278-3-git-send-email-julia@diku.dk> (Julia Lawall's message of "Mon, 4 Jul 2011 16:11:43 +0200")
Julia Lawall <julia@diku.dk> writes:
> From: Julia Lawall <julia@diku.dk>
>
> At this point, the ioremap has taken place, so the error handling code at
> the label err_iounmap should be used rather than returning directly.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier x;
> @@
>
> kfree(x)
>
> @@
> identifier r.x;
> expression E1!=0,E2,E3,E4;
> statement S;
> @@
>
> (
> if (<+...x...+>) S
> |
> if (...) { ... when != kfree(x)
> when != if (...) { ... kfree(x); ... }
> when != x = E3
> * return E1;
> }
> ... when != x = E2
> if (...) { ... when != x = E4
> kfree(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Kevin Hilman <khilman@ti.com>
Tony, can you add this to devel-fixes?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@ti.com>
To: Julia Lawall <julia@diku.dk>
Cc: Tony Lindgren <tony@atomide.com>,
kernel-janitors@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code
Date: Tue, 05 Jul 2011 10:51:13 -0700 [thread overview]
Message-ID: <87tyb0sjji.fsf@ti.com> (raw)
In-Reply-To: <1309788705-22278-3-git-send-email-julia@diku.dk> (Julia Lawall's message of "Mon, 4 Jul 2011 16:11:43 +0200")
Julia Lawall <julia@diku.dk> writes:
> From: Julia Lawall <julia@diku.dk>
>
> At this point, the ioremap has taken place, so the error handling code at
> the label err_iounmap should be used rather than returning directly.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier x;
> @@
>
> kfree(x)
>
> @@
> identifier r.x;
> expression E1!=0,E2,E3,E4;
> statement S;
> @@
>
> (
> if (<+...x...+>) S
> |
> if (...) { ... when != kfree(x)
> when != if (...) { ... kfree(x); ... }
> when != x = E3
> * return E1;
> }
> ... when != x = E2
> if (...) { ... when != x = E4
> kfree(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Kevin Hilman <khilman@ti.com>
Tony, can you add this to devel-fixes?
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code
Date: Tue, 05 Jul 2011 10:51:13 -0700 [thread overview]
Message-ID: <87tyb0sjji.fsf@ti.com> (raw)
In-Reply-To: <1309788705-22278-3-git-send-email-julia@diku.dk> (Julia Lawall's message of "Mon, 4 Jul 2011 16:11:43 +0200")
Julia Lawall <julia@diku.dk> writes:
> From: Julia Lawall <julia@diku.dk>
>
> At this point, the ioremap has taken place, so the error handling code at
> the label err_iounmap should be used rather than returning directly.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier x;
> @@
>
> kfree(x)
>
> @@
> identifier r.x;
> expression E1!=0,E2,E3,E4;
> statement S;
> @@
>
> (
> if (<+...x...+>) S
> |
> if (...) { ... when != kfree(x)
> when != if (...) { ... kfree(x); ... }
> when != x = E3
> * return E1;
> }
> ... when != x = E2
> if (...) { ... when != x = E4
> kfree(x); ... return ...; }
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Kevin Hilman <khilman@ti.com>
Tony, can you add this to devel-fixes?
Kevin
next prev parent reply other threads:[~2011-07-05 17:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 14:11 [PATCH 3/5] arch/arm/mach-omap2/smartreflex.c: add missing error-handling code Julia Lawall
2011-07-04 14:11 ` Julia Lawall
2011-07-04 14:11 ` Julia Lawall
2011-07-05 17:51 ` Kevin Hilman [this message]
2011-07-05 17:51 ` Kevin Hilman
2011-07-05 17:51 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyb0sjji.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.