From: Kevin Hilman <khilman@ti.com>
To: Hemant Pedanekar <hemantp@ti.com>
Cc: linux-omap@vger.kernel.org, tony@atomide.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources
Date: Mon, 14 Feb 2011 15:27:35 -0800 [thread overview]
Message-ID: <87tyg6xkm0.fsf@ti.com> (raw)
In-Reply-To: <1297695819-27027-1-git-send-email-hemantp@ti.com> (Hemant Pedanekar's message of "Mon, 14 Feb 2011 20:33:39 +0530")
Hemant Pedanekar <hemantp@ti.com> writes:
[...]
> @@ -402,7 +422,7 @@ void __init omap2_init_common_devices(struct omap_sdrc_params *sdrc_cs0,
>
> omap_hwmod_late_init();
>
> - if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
> + if (omap3_has_sdrc()) {
> omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
> _omap2_init_reprogram_sdrc();
> }
At first glance, this one doesn't look quite right. Will
omap3_has_sdrc() be true on 24xx? Please confirm.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources
Date: Mon, 14 Feb 2011 15:27:35 -0800 [thread overview]
Message-ID: <87tyg6xkm0.fsf@ti.com> (raw)
In-Reply-To: <1297695819-27027-1-git-send-email-hemantp@ti.com> (Hemant Pedanekar's message of "Mon, 14 Feb 2011 20:33:39 +0530")
Hemant Pedanekar <hemantp@ti.com> writes:
[...]
> @@ -402,7 +422,7 @@ void __init omap2_init_common_devices(struct omap_sdrc_params *sdrc_cs0,
>
> omap_hwmod_late_init();
>
> - if (cpu_is_omap24xx() || cpu_is_omap34xx()) {
> + if (omap3_has_sdrc()) {
> omap2_sdrc_init(sdrc_cs0, sdrc_cs1);
> _omap2_init_reprogram_sdrc();
> }
At first glance, this one doesn't look quite right. Will
omap3_has_sdrc() be true on 24xx? Please confirm.
Kevin
next prev parent reply other threads:[~2011-02-14 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 15:03 [PATCH RESEND v6 2/4] TI816X: Update common OMAP machine specific sources Hemant Pedanekar
2011-02-14 15:03 ` Hemant Pedanekar
2011-02-14 23:27 ` Kevin Hilman [this message]
2011-02-14 23:27 ` Kevin Hilman
2011-02-15 1:09 ` Pedanekar, Hemant
2011-02-15 1:09 ` Pedanekar, Hemant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyg6xkm0.fsf@ti.com \
--to=khilman@ti.com \
--cc=hemantp@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.