From: Kevin Hilman <khilman@ti.com>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/23] arm: Fix possible null pointer read access
Date: Mon, 31 Jan 2011 08:26:26 -0800 [thread overview]
Message-ID: <87tygp82fh.fsf@ti.com> (raw)
In-Reply-To: <1296415778-4638-1-git-send-email-weil@mail.berlios.de> (Stefan Weil's message of "Sun, 30 Jan 2011 20:29:38 +0100")
Stefan Weil <weil@mail.berlios.de> writes:
> These errors were found by cppcheck:
> arch/arm/mach-omap2/smartreflex.c:784: error: Possible null pointer dereference: sr_info
> arch/arm/mach-omap2/smartreflex.c:799: error: Possible null pointer dereference: sr_info
>
> Both conditional statements are executed when sr_info == NULL,
> so accessing sr_info->voltdm would fail.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-omap@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Thanks, queuing for 2.6.38-rc in my pm-fixes branch.
Kevin
> ---
> arch/arm/mach-omap2/smartreflex.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 77ecebf..af39d17 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -780,8 +780,7 @@ static int omap_sr_autocomp_show(void *data, u64 *val)
> struct omap_sr *sr_info = (struct omap_sr *) data;
>
> if (!sr_info) {
> - pr_warning("%s: omap_sr struct for sr_%s not found\n",
> - __func__, sr_info->voltdm->name);
> + pr_warning("%s: omap_sr struct not found\n", __func__);
> return -EINVAL;
> }
>
> @@ -795,8 +794,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
> struct omap_sr *sr_info = (struct omap_sr *) data;
>
> if (!sr_info) {
> - pr_warning("%s: omap_sr struct for sr_%s not found\n",
> - __func__, sr_info->voltdm->name);
> + pr_warning("%s: omap_sr struct not found\n", __func__);
> return -EINVAL;
> }
>
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 19/23] arm: Fix possible null pointer read access
Date: Mon, 31 Jan 2011 08:26:26 -0800 [thread overview]
Message-ID: <87tygp82fh.fsf@ti.com> (raw)
In-Reply-To: <1296415778-4638-1-git-send-email-weil@mail.berlios.de> (Stefan Weil's message of "Sun, 30 Jan 2011 20:29:38 +0100")
Stefan Weil <weil@mail.berlios.de> writes:
> These errors were found by cppcheck:
> arch/arm/mach-omap2/smartreflex.c:784: error: Possible null pointer dereference: sr_info
> arch/arm/mach-omap2/smartreflex.c:799: error: Possible null pointer dereference: sr_info
>
> Both conditional statements are executed when sr_info == NULL,
> so accessing sr_info->voltdm would fail.
>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: linux-omap at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Thanks, queuing for 2.6.38-rc in my pm-fixes branch.
Kevin
> ---
> arch/arm/mach-omap2/smartreflex.c | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c
> index 77ecebf..af39d17 100644
> --- a/arch/arm/mach-omap2/smartreflex.c
> +++ b/arch/arm/mach-omap2/smartreflex.c
> @@ -780,8 +780,7 @@ static int omap_sr_autocomp_show(void *data, u64 *val)
> struct omap_sr *sr_info = (struct omap_sr *) data;
>
> if (!sr_info) {
> - pr_warning("%s: omap_sr struct for sr_%s not found\n",
> - __func__, sr_info->voltdm->name);
> + pr_warning("%s: omap_sr struct not found\n", __func__);
> return -EINVAL;
> }
>
> @@ -795,8 +794,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
> struct omap_sr *sr_info = (struct omap_sr *) data;
>
> if (!sr_info) {
> - pr_warning("%s: omap_sr struct for sr_%s not found\n",
> - __func__, sr_info->voltdm->name);
> + pr_warning("%s: omap_sr struct not found\n", __func__);
> return -EINVAL;
> }
>
> --
> 1.7.2.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-01-31 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-30 19:29 [PATCH 19/23] arm: Fix possible null pointer read access Stefan Weil
2011-01-30 19:29 ` Stefan Weil
2011-01-31 16:26 ` Kevin Hilman [this message]
2011-01-31 16:26 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tygp82fh.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.