From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Roland McGrath <roland@redhat.com>
Cc: Vitaly Mayatskikh <v.mayatskih@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Introduce "struct wait_info" to simplify wait_task*() pathes
Date: Wed, 13 May 2009 21:05:43 +0200 [thread overview]
Message-ID: <87tz3ozuuw.wl%vmayatsk@redhat.com> (raw)
In-Reply-To: <20090513181358.39DC5FC35D@magilla.sf.frob.com>
At Wed, 13 May 2009 11:13:58 -0700 (PDT), Roland McGrath wrote:
> What's the benefit of this? Those parameters are probably happily in
> registers and compiled well, I would guess. Adding more memory copying
> does not seem like a benefit. Have you verified that your change reduces
> code size or something like that?
Yeah, I was wrong. There's no benefit in size of .text
--
wbr, Vitaly
next prev parent reply other threads:[~2009-05-13 19:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 12:08 [PATCH 0/3] More cleanups in do_wait() pathes Vitaly Mayatskikh
2009-05-13 12:08 ` [PATCH 1/3] Introduce "struct wait_info" to simplify wait_task*() pathes Vitaly Mayatskikh
2009-05-13 18:13 ` Roland McGrath
2009-05-13 19:05 ` Vitaly Mayatskikh [this message]
2009-05-15 17:37 ` Ingo Molnar
2009-05-16 10:45 ` Vitaly Mayatskikh
2009-05-13 12:08 ` [PATCH 2/3] Replace wait_noreap_copyout() by copy_wait_opts_to_user() Vitaly Mayatskikh
2009-05-13 12:08 ` [PATCH 3/3] Move more common code from wait_task_*() to copy_wait_opts_to_user() Vitaly Mayatskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz3ozuuw.wl%vmayatsk@redhat.com \
--to=v.mayatskih@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.