Re: [PATCH v2] thermal/drivers: Remove redundant error messages on IRQ request failure

From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Pan Chuang <panchuang@vivo.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	"Daniel Lezcano" <daniel.lezcano@kernel.org>,
	"Zhang Rui" <rui.zhang@intel.com>,
	"Lukasz Luba" <lukasz.luba@arm.com>,
	"Markus Mayer" <mmayer@broadcom.com>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Frank Li" <Frank.Li@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	zhanghongchen <zhanghongchen@loongson.cn>,
	"Yinbo Zhu" <zhuyinbo@loongson.cn>,
	"Amit Kucheria" <amitk@kernel.org>,
	"Thara Gopinath" <thara.gopinath@gmail.com>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Magnus Damm" <magnus.damm@gmail.com>,
	"John Madieu" <john.madieu.xa@bp.renesas.com>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Peter Griffin" <peter.griffin@linaro.org>,
	"Alim Akhtar" <alim.akhtar@samsung.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Thierry Reding" <thierry.reding@kernel.org>,
	"Jonathan Hunter" <jonathanh@nvidia.com>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Srinivas Pandruvada" <srinivas.pandruvada@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Laura Nao" <laura.nao@collabora.com>,
	"Fei Shao" <fshao@chromium.org>,
	"Chen-Yu Tsai" <wenst@chromium.org>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Frank Wunderlich" <frank-w@public-files.de>,
	"Mikko Perttunen" <mperttunen@nvidia.com>,
	"Svyatoslav Ryhel" <clamor95@gmail.com>,
	linux-pm@vger.kernel.org (open list:THERMAL),
	linux-kernel@vger.kernel.org (open list),
	linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM7XXX ARM ARCHITECTURE),
	imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
	ARCHITECTURE),
	linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM MAILING
	LIST),
	linux-renesas-soc@vger.kernel.org (open list:RENESAS R-CAR
	THERMAL DRIVERS),
	linux-rockchip@lists.infradead.org (open list:ARM/Rockchip SoC
	support),
	linux-samsung-soc@vger.kernel.org (open list:SAMSUNG THERMAL
	DRIVER),
	linux-stm32@st-md-mailman.stormreply.com (moderated
	list:ARM/STM32 ARCHITECTURE),
	linux-tegra@vger.kernel.org (open list:TEGRA ARCHITECTURE
	SUPPORT),
	linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek
	SoC support:Keyword:mediatek),
	"Niklas S?derlund" <niklas.soderlund+renesas@ragnatech.se>
Subject: Re: [PATCH v2] thermal/drivers: Remove redundant error messages on IRQ request failure
Date: Fri, 17 Jul 2026 09:37:18 +0200	[thread overview]
Message-ID: <87v7aekqxd.fsf@bootlin.com> (raw)
In-Reply-To: <20260717024733.374913-1-panchuang@vivo.com> (Pan Chuang's message of "Fri, 17 Jul 2026 10:47:10 +0800")

On 17/07/2026 at 10:47:10 +08, Pan Chuang <panchuang@vivo.com> wrote:

> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
> automatically log detailed error messages on failure. Remove the
> now-redundant driver-specific dev_err() and dev_err_probe() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Reviewed-by: Niklas S?derlund <niklas.soderlund+renesas@ragnatech.se>

                       ^
There is an encoding issue here

>  drivers/thermal/armada_thermal.c                          | 5 +----

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl