* [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter
@ 2026-05-28 20:12 Peter Xu
2026-05-28 21:08 ` Fabiano Rosas
2026-06-01 5:40 ` Markus Armbruster
0 siblings, 2 replies; 4+ messages in thread
From: Peter Xu @ 2026-05-28 20:12 UTC (permalink / raw)
To: qemu-devel; +Cc: peterx, Eric Blake, Markus Armbruster, Fabiano Rosas
This parameter was developed during similar window when the deduplication
work was done, hence overlooked. MigrationParameter is already in
exception list of doc sanity checker.
Signed-off-by: Peter Xu <peterx@redhat.com>
---
qapi/migration.json | 4 ----
1 file changed, 4 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 27a7970556..e8756308cf 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -804,10 +804,6 @@
# Migration parameters enumeration. The enumeration values mirror the
# members of @MigrationParameters.
#
-# @cpr-exec-command: Command to start the new QEMU process when @mode
-# is @cpr-exec. The first list element is the program's filename,
-# the remainder its arguments. (Since 10.2)
-#
# Features:
#
# @unstable: Members @x-checkpoint-delay, @x-rdma-chunk-size, and
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter
2026-05-28 20:12 [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter Peter Xu
@ 2026-05-28 21:08 ` Fabiano Rosas
2026-06-01 5:40 ` Markus Armbruster
1 sibling, 0 replies; 4+ messages in thread
From: Fabiano Rosas @ 2026-05-28 21:08 UTC (permalink / raw)
To: Peter Xu, qemu-devel; +Cc: peterx, Eric Blake, Markus Armbruster
Peter Xu <peterx@redhat.com> writes:
> This parameter was developed during similar window when the deduplication
> work was done, hence overlooked. MigrationParameter is already in
> exception list of doc sanity checker.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> qapi/migration.json | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 27a7970556..e8756308cf 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -804,10 +804,6 @@
> # Migration parameters enumeration. The enumeration values mirror the
> # members of @MigrationParameters.
> #
> -# @cpr-exec-command: Command to start the new QEMU process when @mode
> -# is @cpr-exec. The first list element is the program's filename,
> -# the remainder its arguments. (Since 10.2)
> -#
> # Features:
> #
> # @unstable: Members @x-checkpoint-delay, @x-rdma-chunk-size, and
Reviewed-by: Fabiano Rosas <farosas@suse.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter
2026-05-28 20:12 [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter Peter Xu
2026-05-28 21:08 ` Fabiano Rosas
@ 2026-06-01 5:40 ` Markus Armbruster
2026-06-01 21:12 ` Peter Xu
1 sibling, 1 reply; 4+ messages in thread
From: Markus Armbruster @ 2026-06-01 5:40 UTC (permalink / raw)
To: Peter Xu; +Cc: qemu-devel, Eric Blake, Fabiano Rosas
Peter Xu <peterx@redhat.com> writes:
> This parameter was developed during similar window when the deduplication
> work was done, hence overlooked. MigrationParameter is already in
> exception list of doc sanity checker.
Pointing to the exact commit(s) would be nice. Not worth a respin,
consider amending when you merge.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> qapi/migration.json | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 27a7970556..e8756308cf 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -804,10 +804,6 @@
> # Migration parameters enumeration. The enumeration values mirror the
> # members of @MigrationParameters.
> #
> -# @cpr-exec-command: Command to start the new QEMU process when @mode
> -# is @cpr-exec. The first list element is the program's filename,
> -# the remainder its arguments. (Since 10.2)
> -#
> # Features:
> #
> # @unstable: Members @x-checkpoint-delay, @x-rdma-chunk-size, and
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter
2026-06-01 5:40 ` Markus Armbruster
@ 2026-06-01 21:12 ` Peter Xu
0 siblings, 0 replies; 4+ messages in thread
From: Peter Xu @ 2026-06-01 21:12 UTC (permalink / raw)
To: Markus Armbruster; +Cc: qemu-devel, Eric Blake, Fabiano Rosas
On Mon, Jun 01, 2026 at 07:40:07AM +0200, Markus Armbruster wrote:
> Peter Xu <peterx@redhat.com> writes:
>
> > This parameter was developed during similar window when the deduplication
> > work was done, hence overlooked. MigrationParameter is already in
> > exception list of doc sanity checker.
>
> Pointing to the exact commit(s) would be nice. Not worth a respin,
> consider amending when you merge.
I queued this patch with commit message amended into below:
qapi/migration: Remove @cpr-exec-command doc in MigrationParameter
This parameter was developed during similar window when the deduplication
work was done in commit 2220c2b9ef ("qapi/migration: Don't document
MigrationParameter"), hence it was overlooked.
Remove the leftover parameter. After all, MigrationParameter is already in
the exception list of the doc sanity checker.
[...]
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Thanks!
--
Peter Xu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-01 21:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-28 20:12 [PATCH] qapi/migration: Remove @cpr-exec-command doc in MigrationParameter Peter Xu
2026-05-28 21:08 ` Fabiano Rosas
2026-06-01 5:40 ` Markus Armbruster
2026-06-01 21:12 ` Peter Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.