All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Qing Wu <ses1er@gmail.com>
Cc: Michal Simek <michal.simek@amd.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: spinand: dosilicon: Add support for additional models
Date: Wed, 27 May 2026 14:29:39 +0200	[thread overview]
Message-ID: <87v7c9hw7g.fsf@bootlin.com> (raw)
In-Reply-To: <20260527100021.76247-1-ses1er@gmail.com> (Qing Wu's message of "Wed, 27 May 2026 06:00:21 -0400")

On 27/05/2026 at 06:00:21 -04, Qing Wu <ses1er@gmail.com> wrote:

> Add support for additional Dosilicon SPI NAND chips.
>
> Datasheets for chips included in this patch: https://www.dosilicon.com/SPI%20NAND%20Flash.html
>
> Tested on a TP-Link TL-7DR7250 with a Dosilicon DS35Q1GB (0xE5 0xF1)
>
> Signed-off-by: Qing Wu <ses1er@gmail.com>
> ---
> Changes in v3:
> - Changed title
> - Updated 2 bytes for BBM
> - Link to v2: https://lore.kernel.org/all/20260520003733.82514-1-ses1er@gmail.com/
> Changes in v2:
> - Fixed compilation errors.
> - Link to v1: https://lore.kernel.org/all/20260217211427.9120-1-ses1er@gmail.com
> ---
>  drivers/mtd/nand/spi/dosilicon.c | 218 ++++++++++++++++++++++++++++---
>  1 file changed, 203 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/dosilicon.c b/drivers/mtd/nand/spi/dosilicon.c
> index f99899866ceb..fcd967c1bcbc 100644
> --- a/drivers/mtd/nand/spi/dosilicon.c
> +++ b/drivers/mtd/nand/spi/dosilicon.c
> @@ -9,21 +9,27 @@
>  
>  #define SPINAND_MFR_DOSILICON        0xE5
>  
> +#define DOSICON_STATUS_ECC_MASK			GENMASK(6, 4)
> +#define DOSICON_STATUS_ECC_NO_BITFLIPS		(0 << 4)
> +#define DOSICON_STATUS_ECC_1TO3_BITFLIPS	(1 << 4)
> +#define DOSICON_STATUS_ECC_4TO6_BITFLIPS	(3 << 4)
> +#define DOSICON_STATUS_ECC_7TO8_BITFLIPS	(5 << 4)
> +
>  static SPINAND_OP_VARIANTS(read_cache_variants,
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
> +		SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0));

Spurious changes? This cannot be even compile tested.

Please don't rush your v4.

Also please run get_maintainers.pl, the Cc list is not complete.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Qing Wu <ses1er@gmail.com>
Cc: Michal Simek <michal.simek@amd.com>,
	 Vignesh Raghavendra <vigneshr@ti.com>,
	 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mtd: spinand: dosilicon: Add support for additional models
Date: Wed, 27 May 2026 14:29:39 +0200	[thread overview]
Message-ID: <87v7c9hw7g.fsf@bootlin.com> (raw)
In-Reply-To: <20260527100021.76247-1-ses1er@gmail.com> (Qing Wu's message of "Wed, 27 May 2026 06:00:21 -0400")

On 27/05/2026 at 06:00:21 -04, Qing Wu <ses1er@gmail.com> wrote:

> Add support for additional Dosilicon SPI NAND chips.
>
> Datasheets for chips included in this patch: https://www.dosilicon.com/SPI%20NAND%20Flash.html
>
> Tested on a TP-Link TL-7DR7250 with a Dosilicon DS35Q1GB (0xE5 0xF1)
>
> Signed-off-by: Qing Wu <ses1er@gmail.com>
> ---
> Changes in v3:
> - Changed title
> - Updated 2 bytes for BBM
> - Link to v2: https://lore.kernel.org/all/20260520003733.82514-1-ses1er@gmail.com/
> Changes in v2:
> - Fixed compilation errors.
> - Link to v1: https://lore.kernel.org/all/20260217211427.9120-1-ses1er@gmail.com
> ---
>  drivers/mtd/nand/spi/dosilicon.c | 218 ++++++++++++++++++++++++++++---
>  1 file changed, 203 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/mtd/nand/spi/dosilicon.c b/drivers/mtd/nand/spi/dosilicon.c
> index f99899866ceb..fcd967c1bcbc 100644
> --- a/drivers/mtd/nand/spi/dosilicon.c
> +++ b/drivers/mtd/nand/spi/dosilicon.c
> @@ -9,21 +9,27 @@
>  
>  #define SPINAND_MFR_DOSILICON        0xE5
>  
> +#define DOSICON_STATUS_ECC_MASK			GENMASK(6, 4)
> +#define DOSICON_STATUS_ECC_NO_BITFLIPS		(0 << 4)
> +#define DOSICON_STATUS_ECC_1TO3_BITFLIPS	(1 << 4)
> +#define DOSICON_STATUS_ECC_4TO6_BITFLIPS	(3 << 4)
> +#define DOSICON_STATUS_ECC_7TO8_BITFLIPS	(5 << 4)
> +
>  static SPINAND_OP_VARIANTS(read_cache_variants,
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_4S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_2S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_FAST_1S_1S_1S_OP(0, 1, NULL, 0, 0),
> -		SPINAND_PAGE_READ_FROM_CACHE_1S_1S_1S_OP(0, 1, NULL, 0, 0));
> +		SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0),
> +		SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0));

Spurious changes? This cannot be even compile tested.

Please don't rush your v4.

Also please run get_maintainers.pl, the Cc list is not complete.

Thanks,
Miquèl

  reply	other threads:[~2026-05-27 12:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 10:00 [PATCH v3] mtd: spinand: dosilicon: Add support for additional models Qing Wu
2026-05-27 10:00 ` Qing Wu
2026-05-27 12:29 ` Miquel Raynal [this message]
2026-05-27 12:29   ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7c9hw7g.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=michal.simek@amd.com \
    --cc=ses1er@gmail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.