Re: 回复: 回复: Re: 回复: Re: [PATCH] hw/ide: resolve core crash caused by optical drive pop-up during virtual machine startup

Re: 回复: 回复: Re: 回复: Re: [PATCH] hw/ide: resolve core crash caused by optical drive pop-up during virtual machine startup

[Markus Armbruster]

晏龙龙 <yanlonglong@kylinos.cn> writes:

> hi Maintainers :
>
> Do you have any further questions?  I encountered this issue in a production environment,
> and resolving it in the repository resolved the problem ；If you do not agree,  or may be
> change to :
>
> assert(blk_is_available(s->blk));

I'm not the maintainer, I'm just trying to help.  You're not making it
easy, to be frank.

We don't apply patches just because they make a crash go away.  We need
to understand both the bug and the patch.

Working backwards from just the patch to an understanding of the bug is
not practical.  That's why I asked you for a reproducer and/or detailed
analysis of the bug.  Your reply:

    This bug occurs in VDI environments: When a virtual machine boots
    up, the appearance of a CD drive may trigger a core crash. This
    issue has been observed in our internal production environment, and
    our internal testers have already conducted regression testing. You
    may implement this method for testing purposes

This gives us precious little to work with.

What kind of virtual machine?  How do you make a CD drive appear?  Does
it crash always or only sometimes then?  If sometimes, how often?  Stack
backtrace of the crash?  What did your regression testing find, if
anything?  I could go on.  I believe you're sitting on a wealth of
information.  You can't expect us to spend our limited time to
rediscover what you already have, can you?