* [PATCH 1/3] ALSA: us144mkii: Drop kernel-doc markers
2026-02-26 15:43 [PATCH 0/3] ALSA: usb: Fix kernel-doc W=1 warnings Takashi Iwai
@ 2026-02-26 15:43 ` Takashi Iwai
2026-02-26 15:53 ` Takashi Iwai
2026-02-26 15:43 ` [PATCH 2/3] ALSA: usb-audio: Drop superfluous " Takashi Iwai
` (2 subsequent siblings)
3 siblings, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2026-02-26 15:43 UTC (permalink / raw)
To: linux-sound
We don't process this driver code for kernel-doc, and the "/**" marker
leads to warnings with W=1 builds. Drop the superfluous markers, and
also fix the invalid mark up, too.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/usb/usx2y/us144mkii.c | 14 +++++++-------
sound/usb/usx2y/us144mkii_midi.c | 22 +++++++++++-----------
sound/usb/usx2y/us144mkii_playback.c | 10 +++++-----
3 files changed, 23 insertions(+), 23 deletions(-)
diff --git a/sound/usb/usx2y/us144mkii.c b/sound/usb/usx2y/us144mkii.c
index bc71968df8e2..0cf4fa74e210 100644
--- a/sound/usb/usx2y/us144mkii.c
+++ b/sound/usb/usx2y/us144mkii.c
@@ -10,8 +10,8 @@ MODULE_AUTHOR("Šerif Rami <ramiserifpersia@gmail.com>");
MODULE_DESCRIPTION("ALSA Driver for TASCAM US-144MKII");
MODULE_LICENSE("GPL");
-/**
- * @brief Module parameters for ALSA card instantiation.
+/*
+ * Module parameters for ALSA card instantiation.
*
* These parameters allow users to configure how the ALSA sound card
* for the TASCAM US-144MKII is instantiated.
@@ -269,7 +269,7 @@ void tascam_stop_work_handler(struct work_struct *work)
atomic_set(&tascam->active_urbs, 0);
}
-/**
+/*
* tascam_card_private_free() - Frees private data associated with the sound
* card.
* @card: Pointer to the ALSA sound card instance.
@@ -291,7 +291,7 @@ static void tascam_card_private_free(struct snd_card *card)
}
}
-/**
+/*
* tascam_suspend() - Handles device suspension.
* @intf: The USB interface being suspended.
* @message: Power management message.
@@ -332,7 +332,7 @@ static int tascam_suspend(struct usb_interface *intf, pm_message_t message)
return 0;
}
-/**
+/*
* tascam_resume() - Handles device resumption from suspend.
* @intf: The USB interface being resumed.
*
@@ -390,7 +390,7 @@ static void tascam_error_timer(struct timer_list *t)
schedule_work(&tascam->midi_out_work);
}
-/**
+/*
* tascam_probe() - Probes for the TASCAM US-144MKII device.
* @intf: The USB interface being probed.
* @usb_id: The USB device ID.
@@ -565,7 +565,7 @@ static int tascam_probe(struct usb_interface *intf,
return err;
}
-/**
+/*
* tascam_disconnect() - Disconnects the TASCAM US-144MKII device.
* @intf: The USB interface being disconnected.
*
diff --git a/sound/usb/usx2y/us144mkii_midi.c b/sound/usb/usx2y/us144mkii_midi.c
index ed2afec2a89a..4871797b1670 100644
--- a/sound/usb/usx2y/us144mkii_midi.c
+++ b/sound/usb/usx2y/us144mkii_midi.c
@@ -3,7 +3,7 @@
#include "us144mkii.h"
-/**
+/*
* tascam_midi_in_work_handler() - Deferred work for processing MIDI input.
* @work: The work_struct instance.
*
@@ -75,7 +75,7 @@ void tascam_midi_in_urb_complete(struct urb *urb)
usb_put_urb(urb);
}
-/**
+/*
* tascam_midi_in_open() - Opens the MIDI input substream.
* @substream: The ALSA rawmidi substream to open.
*
@@ -92,7 +92,7 @@ static int tascam_midi_in_open(struct snd_rawmidi_substream *substream)
return 0;
}
-/**
+/*
* tascam_midi_in_close() - Closes the MIDI input substream.
* @substream: The ALSA rawmidi substream to close.
*
@@ -103,7 +103,7 @@ static int tascam_midi_in_close(struct snd_rawmidi_substream *substream)
return 0;
}
-/**
+/*
* tascam_midi_in_trigger() - Triggers MIDI input stream activity.
* @substream: The ALSA rawmidi substream.
* @up: Boolean indicating whether to start (1) or stop (0) the stream.
@@ -150,7 +150,7 @@ static void tascam_midi_in_trigger(struct snd_rawmidi_substream *substream,
}
}
-/**
+/*
* tascam_midi_in_ops - ALSA rawmidi operations for MIDI input.
*
* This structure defines the callback functions for MIDI input stream
@@ -205,7 +205,7 @@ void tascam_midi_out_urb_complete(struct urb *urb)
usb_put_urb(urb);
}
-/**
+/*
* tascam_midi_out_work_handler() - Deferred work for sending MIDI data
* @work: The work_struct instance.
*
@@ -282,7 +282,7 @@ static void tascam_midi_out_work_handler(struct work_struct *work)
}
}
-/**
+/*
* tascam_midi_out_open() - Opens the MIDI output substream.
* @substream: The ALSA rawmidi substream to open.
*
@@ -301,7 +301,7 @@ static int tascam_midi_out_open(struct snd_rawmidi_substream *substream)
return 0;
}
-/**
+/*
* tascam_midi_out_close() - Closes the MIDI output substream.
* @substream: The ALSA rawmidi substream to close.
*
@@ -312,7 +312,7 @@ static int tascam_midi_out_close(struct snd_rawmidi_substream *substream)
return 0;
}
-/**
+/*
* tascam_midi_out_drain() - Drains the MIDI output stream.
* @substream: The ALSA rawmidi substream.
*
@@ -340,7 +340,7 @@ static void tascam_midi_out_drain(struct snd_rawmidi_substream *substream)
usb_kill_anchored_urbs(&tascam->midi_out_anchor);
}
-/**
+/*
* tascam_midi_out_trigger() - Triggers MIDI output stream activity.
* @substream: The ALSA rawmidi substream.
* @up: Boolean indicating whether to start (1) or stop (0) the stream.
@@ -361,7 +361,7 @@ static void tascam_midi_out_trigger(struct snd_rawmidi_substream *substream,
}
}
-/**
+/*
* tascam_midi_out_ops - ALSA rawmidi operations for MIDI output.
*
* This structure defines the callback functions for MIDI output stream
diff --git a/sound/usb/usx2y/us144mkii_playback.c b/sound/usb/usx2y/us144mkii_playback.c
index 0cb9699ec211..7efaca0a6489 100644
--- a/sound/usb/usx2y/us144mkii_playback.c
+++ b/sound/usb/usx2y/us144mkii_playback.c
@@ -3,7 +3,7 @@
#include "us144mkii.h"
-/**
+/*
* tascam_playback_open() - Opens the PCM playback substream.
* @substream: The ALSA PCM substream to open.
*
@@ -23,7 +23,7 @@ static int tascam_playback_open(struct snd_pcm_substream *substream)
return 0;
}
-/**
+/*
* tascam_playback_close() - Closes the PCM playback substream.
* @substream: The ALSA PCM substream to close.
*
@@ -41,7 +41,7 @@ static int tascam_playback_close(struct snd_pcm_substream *substream)
return 0;
}
-/**
+/*
* tascam_playback_prepare() - Prepares the PCM playback substream for use.
* @substream: The ALSA PCM substream to prepare.
*
@@ -108,7 +108,7 @@ static int tascam_playback_prepare(struct snd_pcm_substream *substream)
return 0;
}
-/**
+/*
* tascam_playback_pointer() - Returns the current playback pointer position.
* @substream: The ALSA PCM substream.
*
@@ -137,7 +137,7 @@ tascam_playback_pointer(struct snd_pcm_substream *substream)
return do_div(pos, runtime->buffer_size);
}
-/**
+/*
* tascam_playback_ops - ALSA PCM operations for playback.
*
* This structure defines the callback functions for playback stream operations,
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/3] ALSA: usb-audio: Drop superfluous kernel-doc markers
2026-02-26 15:43 [PATCH 0/3] ALSA: usb: Fix kernel-doc W=1 warnings Takashi Iwai
2026-02-26 15:43 ` [PATCH 1/3] ALSA: us144mkii: Drop kernel-doc markers Takashi Iwai
@ 2026-02-26 15:43 ` Takashi Iwai
2026-02-26 15:43 ` [PATCH 3/3] ALSA: usb: qcom: Correct parameter comment for uaudio_transfer_buffer_setup() Takashi Iwai
2026-02-26 15:43 ` [PATCH 4/4] ASoC: SDCA: Fix comments for sdca_irq_request() Takashi Iwai
3 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2026-02-26 15:43 UTC (permalink / raw)
To: linux-sound
We don't process USB-audio driver code for kernel-doc, and the "/**"
marker leads to warnings with W=1 builds. Drop the superfluous
markers.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/usb/mixer_s1810c.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/usb/mixer_s1810c.c b/sound/usb/mixer_s1810c.c
index 473cb29efa7f..7eac7d1bce64 100644
--- a/sound/usb/mixer_s1810c.c
+++ b/sound/usb/mixer_s1810c.c
@@ -71,7 +71,7 @@
* * e I guess the same as with mixer
*
*/
-/** struct s1810c_ctl_packet - basic vendor request
+/* struct s1810c_ctl_packet - basic vendor request
* @selector: device/mixer/output
* @b: request-dependant field b
* @tag: fixed value identifying type of request
@@ -94,14 +94,14 @@ struct s1810c_ctl_packet {
__le32 e;
};
-/** selectors for CMD request
+/* selectors for CMD request
*/
#define SC1810C_SEL_DEVICE 0
#define SC1810C_SEL_MIXER 0x64
#define SC1810C_SEL_OUTPUT 0x65
-/** control ids */
+/* control ids */
#define SC1810C_CTL_LINE_SW 0
#define SC1810C_CTL_MUTE_SW 1
#define SC1824C_CTL_MONO_SW 2
@@ -127,7 +127,7 @@ struct s1810c_ctl_packet {
#define SC1810C_GET_STATE_TAG SC1810C_SET_STATE_TAG
#define SC1810C_GET_STATE_LEN SC1810C_SET_STATE_LEN
-/** Mixer levels normally range from 0 (off) to 0x0100 0000 (0 dB).
+/* Mixer levels normally range from 0 (off) to 0x0100 0000 (0 dB).
* raw_level = 2^24 * 10^(db_level / 20), thus
* -3dB = 0xb53bf0 (technically, half-power -3.01...dB would be 0xb504f3)
* -96dB = 0x109
@@ -145,7 +145,7 @@ struct s1810c_ctl_packet {
#define MIXER_LEVEL_N3DB 0xb53bf0
#define MIXER_LEVEL_0DB 0x1000000
-/**
+/*
* This packet includes mixer volumes and
* various other fields, it's an extended
* version of ctl_packet, with a and b
@@ -155,7 +155,7 @@ struct s1810c_state_packet {
__le32 fields[63];
};
-/** indices into s1810c_state_packet.fields[]
+/* indices into s1810c_state_packet.fields[]
*/
#define SC1810C_STATE_TAG_IDX 2
#define SC1810C_STATE_LEN_IDX 3
--
2.53.0
^ permalink raw reply related [flat|nested] 7+ messages in thread