All of lore.kernel.org
 help / color / mirror / Atom feed
* [tip:timers/core] BUILD SUCCESS WITH UNVERIFIED WARNING 7dec062cfcf27808dbb70a0b231d1a698792743d
@ 2025-11-22  7:20 kernel test robot
  2025-11-22 15:43 ` Thomas Gleixner
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2025-11-22  7:20 UTC (permalink / raw)
  To: x86-ml; +Cc: linux-kernel

tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
branch HEAD: 7dec062cfcf27808dbb70a0b231d1a698792743d  timers/migration: Exclude isolated cpus from hierarchy

Unverified Warning (likely false positive, kindly check if interested):

    kernel/time/timer_migration.c:1866 tmigr_setup_groups() error: we previously assumed 'start' could be null (see line 1764)

Warning ids grouped by kconfigs:

recent_errors
`-- arm64-randconfig-r071-20251122
    `-- kernel-time-timer_migration.c-tmigr_setup_groups()-error:we-previously-assumed-start-could-be-null-(see-line-)

elapsed time: 2095m

configs tested: 99
configs skipped: 3

tested configs:
alpha                             allnoconfig    gcc-15.1.0
alpha                               defconfig    gcc-15.1.0
arc                               allnoconfig    gcc-15.1.0
arc                   randconfig-001-20251121    gcc-8.5.0
arc                   randconfig-002-20251121    gcc-13.4.0
arm                               allnoconfig    clang-22
arm                   randconfig-001-20251121    gcc-10.5.0
arm                   randconfig-002-20251121    gcc-11.5.0
arm                   randconfig-003-20251121    clang-22
arm                   randconfig-004-20251121    gcc-10.5.0
arm64                             allnoconfig    gcc-15.1.0
arm64                 randconfig-001-20251122    gcc-8.5.0
arm64                 randconfig-002-20251122    gcc-9.5.0
arm64                 randconfig-003-20251122    gcc-10.5.0
arm64                 randconfig-004-20251122    clang-22
csky                              allnoconfig    gcc-15.1.0
csky                  randconfig-001-20251122    gcc-15.1.0
csky                  randconfig-002-20251122    gcc-14.3.0
hexagon                           allnoconfig    clang-22
hexagon               randconfig-001-20251121    clang-22
hexagon               randconfig-002-20251121    clang-22
i386                              allnoconfig    gcc-14
i386        buildonly-randconfig-001-20251122    clang-20
i386        buildonly-randconfig-002-20251122    clang-20
i386        buildonly-randconfig-003-20251122    gcc-14
i386        buildonly-randconfig-004-20251122    clang-20
i386        buildonly-randconfig-005-20251122    clang-20
i386        buildonly-randconfig-006-20251122    clang-20
i386                  randconfig-001-20251122    clang-20
i386                  randconfig-002-20251122    gcc-13
i386                  randconfig-003-20251122    clang-20
i386                  randconfig-004-20251122    clang-20
i386                  randconfig-005-20251122    clang-20
i386                  randconfig-006-20251122    clang-20
i386                  randconfig-007-20251122    clang-20
loongarch                         allnoconfig    clang-22
loongarch                           defconfig    clang-19
loongarch             randconfig-001-20251121    gcc-15.1.0
loongarch             randconfig-002-20251121    clang-22
m68k                              allnoconfig    gcc-15.1.0
m68k                                defconfig    gcc-15.1.0
microblaze                        allnoconfig    gcc-15.1.0
microblaze                          defconfig    gcc-15.1.0
mips                              allnoconfig    gcc-15.1.0
mips                          rb532_defconfig    clang-18
nios2                             allnoconfig    gcc-11.5.0
nios2                               defconfig    gcc-11.5.0
nios2                 randconfig-001-20251121    gcc-11.5.0
nios2                 randconfig-002-20251121    gcc-8.5.0
openrisc                          allnoconfig    gcc-15.1.0
openrisc                            defconfig    gcc-15.1.0
parisc                            allnoconfig    gcc-15.1.0
parisc                              defconfig    gcc-15.1.0
parisc64                            defconfig    gcc-15.1.0
powerpc                           allnoconfig    gcc-15.1.0
powerpc                      chrp32_defconfig    clang-19
powerpc               mpc834x_itxgp_defconfig    clang-22
powerpc                         ps3_defconfig    gcc-15.1.0
riscv                             allnoconfig    gcc-15.1.0
riscv                               defconfig    clang-22
riscv                 randconfig-001-20251122    clang-22
riscv                 randconfig-002-20251122    clang-22
s390                              allnoconfig    clang-22
s390                                defconfig    clang-22
s390                  randconfig-001-20251122    clang-16
s390                  randconfig-002-20251122    gcc-13.4.0
sh                                allnoconfig    gcc-15.1.0
sh                                  defconfig    gcc-15.1.0
sh                            hp6xx_defconfig    gcc-15.1.0
sh                    randconfig-001-20251122    gcc-15.1.0
sh                    randconfig-002-20251122    gcc-10.5.0
sh                             sh03_defconfig    gcc-15.1.0
sparc                             allnoconfig    gcc-15.1.0
sparc                               defconfig    gcc-15.1.0
sparc                 randconfig-001-20251121    gcc-13.4.0
sparc                 randconfig-002-20251121    gcc-8.5.0
sparc64                             defconfig    clang-20
sparc64               randconfig-001-20251121    clang-22
sparc64               randconfig-002-20251121    clang-22
um                                allnoconfig    clang-22
um                                  defconfig    clang-22
um                             i386_defconfig    gcc-14
um                    randconfig-001-20251121    clang-22
um                    randconfig-002-20251121    gcc-14
um                           x86_64_defconfig    clang-22
x86_64                            allnoconfig    clang-20
x86_64      buildonly-randconfig-001-20251122    gcc-14
x86_64      buildonly-randconfig-002-20251122    gcc-14
x86_64      buildonly-randconfig-003-20251122    gcc-14
x86_64      buildonly-randconfig-004-20251122    clang-20
x86_64      buildonly-randconfig-005-20251122    gcc-14
x86_64      buildonly-randconfig-006-20251122    gcc-13
x86_64                              defconfig    gcc-14
x86_64                randconfig-071-20251122    gcc-14
x86_64                randconfig-072-20251122    gcc-14
x86_64                randconfig-074-20251122    gcc-14
xtensa                            allnoconfig    gcc-15.1.0
xtensa                randconfig-001-20251121    gcc-11.5.0
xtensa                randconfig-002-20251121    gcc-8.5.0

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [tip:timers/core] BUILD SUCCESS WITH UNVERIFIED WARNING 7dec062cfcf27808dbb70a0b231d1a698792743d
  2025-11-22  7:20 [tip:timers/core] BUILD SUCCESS WITH UNVERIFIED WARNING 7dec062cfcf27808dbb70a0b231d1a698792743d kernel test robot
@ 2025-11-22 15:43 ` Thomas Gleixner
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Gleixner @ 2025-11-22 15:43 UTC (permalink / raw)
  To: kernel test robot, x86-ml; +Cc: linux-kernel, Frederic Weisbecker

On Sat, Nov 22 2025 at 15:20, kernel test robot wrote:

> tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git timers/core
> branch HEAD: 7dec062cfcf27808dbb70a0b231d1a698792743d  timers/migration: Exclude isolated cpus from hierarchy
>
> Unverified Warning (likely false positive, kindly check if interested):
>
>     kernel/time/timer_migration.c:1866 tmigr_setup_groups() error: we previously assumed 'start' could be null (see line 1764)

Yes, the code is prone to that problem, but the two callers do the right
thing. Though this can be simplified.

Thanks

        tglx
---
 kernel/time/timer_migration.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--- a/kernel/time/timer_migration.c
+++ b/kernel/time/timer_migration.c
@@ -1750,12 +1750,12 @@ static void tmigr_connect_child_parent(s
 	trace_tmigr_connect_child_parent(child);
 }
 
-static int tmigr_setup_groups(unsigned int cpu, unsigned int node,
-			      struct tmigr_group *start, bool activate)
+static int tmigr_setup_groups(unsigned int cpu, unsigned int node, struct tmigr_group *start)
 {
 	struct tmigr_group *group, *child, **stack;
 	int i, top = 0, err = 0, start_lvl = 0;
 	bool root_mismatch = false;
+	bool activate = false;
 
 	stack = kcalloc(tmigr_hierarchy_levels, sizeof(*stack), GFP_KERNEL);
 	if (!stack)
@@ -1764,6 +1764,7 @@ static int tmigr_setup_groups(unsigned i
 	if (start) {
 		stack[start->level] = start;
 		start_lvl = start->level + 1;
+		activate = true;
 	}
 
 	if (tmigr_root)
@@ -1893,7 +1894,7 @@ static int tmigr_add_cpu(unsigned int cp
 
 	guard(mutex)(&tmigr_mutex);
 
-	ret = tmigr_setup_groups(cpu, node, NULL, false);
+	ret = tmigr_setup_groups(cpu, node, NULL);
 
 	/* Root has changed? Connect the old one to the new */
 	if (ret >= 0 && old_root && old_root != tmigr_root) {
@@ -1910,7 +1911,7 @@ static int tmigr_add_cpu(unsigned int cp
 		 * otherwise the old root may not be active as expected.
 		 */
 		WARN_ON_ONCE(!per_cpu_ptr(&tmigr_cpu, raw_smp_processor_id())->available);
-		ret = tmigr_setup_groups(-1, old_root->numa_node, old_root, true);
+		ret = tmigr_setup_groups(-1, old_root->numa_node, old_root);
 	}
 
 	return ret;


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-22 15:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-22  7:20 [tip:timers/core] BUILD SUCCESS WITH UNVERIFIED WARNING 7dec062cfcf27808dbb70a0b231d1a698792743d kernel test robot
2025-11-22 15:43 ` Thomas Gleixner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.