All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: richard@nod.at,  vigneshr@ti.com,  vz@mleia.com,
	piotr.wojtaszczyk@timesys.com,  linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: lpc32xx_slc: fix GPIO descriptor leak
Date: Tue, 04 Nov 2025 09:55:37 +0100	[thread overview]
Message-ID: <87v7jq9nxy.fsf@bootlin.com> (raw)
In-Reply-To: <20251104014042.1389-1-vulab@iscas.ac.cn> (Haotian Zhang's message of "Tue, 4 Nov 2025 09:40:42 +0800")

Hi,

> diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
> index b54d76547ffb..3ca30e7dce33 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
> @@ -854,7 +854,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Start with WP disabled, if available */
> -	host->wp_gpio = gpiod_get_optional(&pdev->dev, NULL, GPIOD_OUT_LOW);
> +	host->wp_gpio = devm_gpiod_get_optional(&pdev->dev, NULL,
>  	GPIOD_OUT_LOW);

Please send an update on top the previous patch which I already applied.

Thanks,
Miquèl


WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Haotian Zhang <vulab@iscas.ac.cn>
Cc: richard@nod.at,  vigneshr@ti.com,  vz@mleia.com,
	piotr.wojtaszczyk@timesys.com,  linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mtd: rawnand: lpc32xx_slc: fix GPIO descriptor leak
Date: Tue, 04 Nov 2025 09:55:37 +0100	[thread overview]
Message-ID: <87v7jq9nxy.fsf@bootlin.com> (raw)
In-Reply-To: <20251104014042.1389-1-vulab@iscas.ac.cn> (Haotian Zhang's message of "Tue, 4 Nov 2025 09:40:42 +0800")

Hi,

> diff --git a/drivers/mtd/nand/raw/lpc32xx_slc.c b/drivers/mtd/nand/raw/lpc32xx_slc.c
> index b54d76547ffb..3ca30e7dce33 100644
> --- a/drivers/mtd/nand/raw/lpc32xx_slc.c
> +++ b/drivers/mtd/nand/raw/lpc32xx_slc.c
> @@ -854,7 +854,7 @@ static int lpc32xx_nand_probe(struct platform_device *pdev)
>  	}
>  
>  	/* Start with WP disabled, if available */
> -	host->wp_gpio = gpiod_get_optional(&pdev->dev, NULL, GPIOD_OUT_LOW);
> +	host->wp_gpio = devm_gpiod_get_optional(&pdev->dev, NULL,
>  	GPIOD_OUT_LOW);

Please send an update on top the previous patch which I already applied.

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2025-11-04  8:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28  9:47 [PATCH] mtd: rawnand: lpc32xx_slc: fix GPIO descriptor leak on probe error and remove Haotian Zhang
2025-10-28  9:47 ` Haotian Zhang
2025-10-28 15:59 ` Miquel Raynal
2025-10-28 15:59   ` Miquel Raynal
2025-11-03 16:21 ` Vladimir Zapolskiy
2025-11-03 16:21   ` Vladimir Zapolskiy
2025-11-04  8:27   ` Miquel Raynal
2025-11-04  8:27     ` Miquel Raynal
2025-11-04  1:40 ` [PATCH v2] mtd: rawnand: lpc32xx_slc: fix GPIO descriptor leak Haotian Zhang
2025-11-04  1:40   ` Haotian Zhang
2025-11-04  8:55   ` Miquel Raynal [this message]
2025-11-04  8:55     ` Miquel Raynal
2025-11-04 18:33   ` Markus Elfring
2025-11-04 18:33     ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7jq9nxy.fsf@bootlin.com \
    --to=miquel.raynal@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=vulab@iscas.ac.cn \
    --cc=vz@mleia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.