All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Wang <unicornxw@gmail.com>,
	u.kleine-koenig@baylibre.com, aou@eecs.berkeley.edu,
	unicorn_wang@outlook.com, conor+dt@kernel.org,
	inochiama@gmail.com, krzk+dt@kernel.org, looong.bin@gmail.com,
	palmer@dabbelt.com, paul.walmsley@sifive.com, robh@kernel.org,
	sycamoremoon376@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	sophgo@lists.linux.dev
Subject: Re: [PATCH v2 1/3] irqchip/sg2042-msi: Set irq type according to DT configuration
Date: Tue, 02 Sep 2025 15:11:27 +0200	[thread overview]
Message-ID: <87v7m10zk0.ffs@tglx> (raw)
In-Reply-To: <49e70989c2f0a8a67e48527e57b4877262996214.1756169460.git.unicorn_wang@outlook.com>

On Tue, Aug 26 2025 at 09:09, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> The original MSI interrupt type was hard-coded, which was not a good idea.

That's not really helpful, unless you explain WHY it's not a good
idea...

Also for correctness sake, you want to change the DTs first and not
after you changed the driver to read it from the stale device tree with
the wrong type.

Thanks,

        tglx

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: Chen Wang <unicornxw@gmail.com>,
	u.kleine-koenig@baylibre.com, aou@eecs.berkeley.edu,
	unicorn_wang@outlook.com, conor+dt@kernel.org,
	inochiama@gmail.com, krzk+dt@kernel.org, looong.bin@gmail.com,
	palmer@dabbelt.com, paul.walmsley@sifive.com, robh@kernel.org,
	sycamoremoon376@gmail.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
	sophgo@lists.linux.dev
Subject: Re: [PATCH v2 1/3] irqchip/sg2042-msi: Set irq type according to DT configuration
Date: Tue, 02 Sep 2025 15:11:27 +0200	[thread overview]
Message-ID: <87v7m10zk0.ffs@tglx> (raw)
In-Reply-To: <49e70989c2f0a8a67e48527e57b4877262996214.1756169460.git.unicorn_wang@outlook.com>

On Tue, Aug 26 2025 at 09:09, Chen Wang wrote:
> From: Chen Wang <unicorn_wang@outlook.com>
>
> The original MSI interrupt type was hard-coded, which was not a good idea.

That's not really helpful, unless you explain WHY it's not a good
idea...

Also for correctness sake, you want to change the DTs first and not
after you changed the driver to read it from the stale device tree with
the wrong type.

Thanks,

        tglx

  reply	other threads:[~2025-09-02 19:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26  1:09 [PATCH v2 0/3] irqchip/sg2042-msi: Set irq type according to DT configuration Chen Wang
2025-08-26  1:09 ` Chen Wang
2025-08-26  1:09 ` [PATCH v2 1/3] " Chen Wang
2025-08-26  1:09   ` Chen Wang
2025-09-02 13:11   ` Thomas Gleixner [this message]
2025-09-02 13:11     ` Thomas Gleixner
2025-08-26  1:09 ` [PATCH v2 2/3] riscv: sophgo: dts: sg2042: change msi irq type to IRQ_TYPE_EDGE_RISING Chen Wang
2025-08-26  1:09   ` Chen Wang
2025-08-26  1:10 ` [PATCH v2 3/3] riscv: sophgo: dts: sg2044: " Chen Wang
2025-08-26  1:10   ` Chen Wang
2025-09-01 22:16 ` [PATCH v2 0/3] irqchip/sg2042-msi: Set irq type according to DT configuration Inochi Amaoto
2025-09-01 22:16   ` Inochi Amaoto
2025-09-01 23:59 ` Chen Wang
2025-09-01 23:59   ` Chen Wang
2025-09-02 13:12   ` Thomas Gleixner
2025-09-02 13:12     ` Thomas Gleixner
2025-09-03  0:37     ` Chen Wang
2025-09-03  0:37       ` Chen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v7m10zk0.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=inochiama@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=looong.bin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sophgo@lists.linux.dev \
    --cc=sycamoremoon376@gmail.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=unicorn_wang@outlook.com \
    --cc=unicornxw@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.