Re: [PATCH V5 38/38] vfio: doc changes for cpr

[Fabiano Rosas <farosas@suse.de>]

Steve Sistare <steven.sistare@oracle.com> writes:

> Update documentation to say that cpr-transfer supports vfio and iommufd.
>
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> ---
>  docs/devel/migration/CPR.rst | 5 ++---
>  qapi/migration.json          | 6 ++++--
>  2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/docs/devel/migration/CPR.rst b/docs/devel/migration/CPR.rst
> index 7897873..0a0fd4f 100644
> --- a/docs/devel/migration/CPR.rst
> +++ b/docs/devel/migration/CPR.rst
> @@ -152,8 +152,7 @@ cpr-transfer mode
>  This mode allows the user to transfer a guest to a new QEMU instance
>  on the same host with minimal guest pause time, by preserving guest
>  RAM in place, albeit with new virtual addresses in new QEMU.  Devices
> -and their pinned memory pages will also be preserved in a future QEMU
> -release.
> +and their pinned memory pages are also preserved for VFIO and IOMMUFD.
>  
>  The user starts new QEMU on the same host as old QEMU, with command-
>  line arguments to create the same machine, plus the ``-incoming``
> @@ -322,6 +321,6 @@ Futures
>  
>  cpr-transfer mode is based on a capability to transfer open file
>  descriptors from old to new QEMU.  In the future, descriptors for
> -vfio, iommufd, vhost, and char devices could be transferred,
> +vhost, and char devices could be transferred,
>  preserving those devices and their kernel state without interruption,
>  even if they do not explicitly support live migration.
> diff --git a/qapi/migration.json b/qapi/migration.json
> index 4963f6c..e8a7d3b 100644
> --- a/qapi/migration.json
> +++ b/qapi/migration.json
> @@ -620,8 +620,10 @@
>  #
>  # @cpr-transfer: This mode allows the user to transfer a guest to a
>  #     new QEMU instance on the same host with minimal guest pause
> -#     time by preserving guest RAM in place.  Devices and their pinned
> -#     pages will also be preserved in a future QEMU release.
> +#     time by preserving guest RAM in place.
> +#
> +#     Devices and their pinned pages are also preserved for VFIO and
> +#     IOMMUFD. (since 10.1)
>  #
>  #     The user starts new QEMU on the same host as old QEMU, with
>  #     command-line arguments to create the same machine, plus the

Reviewed-by: Fabiano Rosas <farosas@suse.de>