Re: [PATCH 01/21] mtd: spinand: Use more specific naming for the reset op

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Tudor,

>> -#define SPINAND_RESET_OP						\
>> +#define SPINAND_RESET_1S_0_0_OP						\
> Hi, Miquel,
>
> Have you seen any reset op with address or data? If not, I'm not really
> sure whether we shall change the name for these basic operations.
>
> Changing them to 1S-0-0 may also indicate that there are resets with
> address or data fields, which I find confusing.
>
> I think the change is good for reads and writes. I'll check further in
> the series and let you know.

I want to rename this macro for two reasons:
- We might see in the near future the addition of 8D-0-0 ops (I plan on
  working on it).
- I would like some kind of harmony among these macros.

Now, whether is should be named like I proposed or just
SPINAND_RESET_OP_1S, I have no strong preference and I can change that
in an upcoming version.

Which one would you prefer?

Cheers,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/