Re: [PATCH v2] mmc: Hide mmc speed command under mmc command

[Mattijs Korpershoek <mkorpershoek@baylibre.com>]

On lun., sept. 02, 2024 at 15:41, Quentin Schulz <quentin.schulz@cherry.de> wrote:

> Hi Marek,
>
> On 9/2/24 3:37 PM, Marek Vasut wrote:
>> The mmc speed command configuration option keeps showing up in
>> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
>> under CMD_MMC to make it show up alongside the MMC command.
>> 
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
>> Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
>> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> Cc: Michal Simek <michal.simek@amd.com>
>> Cc: Quentin Schulz <quentin.schulz@cherry.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: u-boot@lists.denx.de
>> ---
>> V2: Rework the commit message
>
> Better, thanks :)
>
>> ---
>>   cmd/Kconfig | 19 +++++++++----------
>>   1 file changed, 9 insertions(+), 10 deletions(-)
>> 
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index 43f78a5aeb1..953e1f0ef2a 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
>>   	  Enable support for the "mmc swrite" command to write Android sparse
>>   	  images to eMMC.
>>   
>> +config MMC_SPEED_MODE_SET
>
> I'm wondering if we should prefix this with CMD_ maybe? It's used in 
> drivers/mmc/ though.
>
> Anyway, not a blocker for this.
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> (You forgot Mattijs's Rb from v1 BTW)

Giving it again, thank you for noticing :)

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> Thanks!
> Quentin