[PATCH v2] mmc: Hide mmc speed command under mmc command

[PATCH v2] mmc: Hide mmc speed command under mmc command

[Marek Vasut]

The mmc speed command configuration option keeps showing up in
Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
under CMD_MMC to make it show up alongside the MMC command.

Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
---
Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Michal Simek <michal.simek@amd.com>
Cc: Quentin Schulz <quentin.schulz@cherry.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: u-boot@lists.denx.de
---
V2: Rework the commit message
---
 cmd/Kconfig | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 43f78a5aeb1..953e1f0ef2a 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
 	  Enable support for the "mmc swrite" command to write Android sparse
 	  images to eMMC.
 
+config MMC_SPEED_MODE_SET
+	bool "set speed mode using mmc command"
+	help
+	  Enable setting speed mode using mmc rescan and mmc dev commands.
+	  The speed mode is provided as the last argument in these commands
+	  and is indicated using the index from enum bus_mode in
+	  include/mmc.h. A speed mode can be set only if it has already
+	  been enabled in the device tree.
+
 endif
 
 config CMD_CLONE
@@ -2971,16 +2980,6 @@ config CMD_UBIFS
 	help
 	  UBIFS is a file system for flash devices which works on top of UBI.
 
-config MMC_SPEED_MODE_SET
-	bool "set speed mode using mmc command"
-	depends on CMD_MMC
-	help
-	  Enable setting speed mode using mmc rescan and mmc dev commands.
-	  The speed mode is provided as the last argument in these commands
-	  and is indicated using the index from enum bus_mode in
-	  include/mmc.h. A speed mode can be set only if it has already
-	  been enabled in the device tree.
-
 config CMD_MESON
 	bool "Amlogic Meson commands"
 	depends on ARCH_MESON
-- 
2.45.2

Re: [PATCH v2] mmc: Hide mmc speed command under mmc command

[Quentin Schulz]

Hi Marek,

On 9/2/24 3:37 PM, Marek Vasut wrote:
> The mmc speed command configuration option keeps showing up in
> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
> under CMD_MMC to make it show up alongside the MMC command.
> 
> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> ---
> Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
> Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Michal Simek <michal.simek@amd.com>
> Cc: Quentin Schulz <quentin.schulz@cherry.de>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@lists.denx.de
> ---
> V2: Rework the commit message

Better, thanks :)

> ---
>   cmd/Kconfig | 19 +++++++++----------
>   1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 43f78a5aeb1..953e1f0ef2a 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
>   	  Enable support for the "mmc swrite" command to write Android sparse
>   	  images to eMMC.
>   
> +config MMC_SPEED_MODE_SET

I'm wondering if we should prefix this with CMD_ maybe? It's used in 
drivers/mmc/ though.

Anyway, not a blocker for this.

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

(You forgot Mattijs's Rb from v1 BTW)

Thanks!
Quentin

Re: [PATCH v2] mmc: Hide mmc speed command under mmc command

[Mattijs Korpershoek]

On lun., sept. 02, 2024 at 15:41, Quentin Schulz <quentin.schulz@cherry.de> wrote:

> Hi Marek,
>
> On 9/2/24 3:37 PM, Marek Vasut wrote:
>> The mmc speed command configuration option keeps showing up in
>> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
>> under CMD_MMC to make it show up alongside the MMC command.
>> 
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>> ---
>> Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
>> Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
>> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>> Cc: Michal Simek <michal.simek@amd.com>
>> Cc: Quentin Schulz <quentin.schulz@cherry.de>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: u-boot@lists.denx.de
>> ---
>> V2: Rework the commit message
>
> Better, thanks :)
>
>> ---
>>   cmd/Kconfig | 19 +++++++++----------
>>   1 file changed, 9 insertions(+), 10 deletions(-)
>> 
>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>> index 43f78a5aeb1..953e1f0ef2a 100644
>> --- a/cmd/Kconfig
>> +++ b/cmd/Kconfig
>> @@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
>>   	  Enable support for the "mmc swrite" command to write Android sparse
>>   	  images to eMMC.
>>   
>> +config MMC_SPEED_MODE_SET
>
> I'm wondering if we should prefix this with CMD_ maybe? It's used in 
> drivers/mmc/ though.
>
> Anyway, not a blocker for this.
>
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>
> (You forgot Mattijs's Rb from v1 BTW)

Giving it again, thank you for noticing :)

Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

>
> Thanks!
> Quentin

Re: [PATCH v2] mmc: Hide mmc speed command under mmc command

[Marek Vasut]

On 9/3/24 9:42 AM, Mattijs Korpershoek wrote:
> On lun., sept. 02, 2024 at 15:41, Quentin Schulz <quentin.schulz@cherry.de> wrote:
> 
>> Hi Marek,
>>
>> On 9/2/24 3:37 PM, Marek Vasut wrote:
>>> The mmc speed command configuration option keeps showing up in
>>> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
>>> under CMD_MMC to make it show up alongside the MMC command.
>>>
>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
>>> ---
>>> Cc: AKASHI Takahiro <akashi.tkhro@gmail.com>
>>> Cc: Francis Laniel <francis.laniel@amarulasolutions.com>
>>> Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
>>> Cc: Michal Simek <michal.simek@amd.com>
>>> Cc: Quentin Schulz <quentin.schulz@cherry.de>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: u-boot@lists.denx.de
>>> ---
>>> V2: Rework the commit message
>>
>> Better, thanks :)
>>
>>> ---
>>>    cmd/Kconfig | 19 +++++++++----------
>>>    1 file changed, 9 insertions(+), 10 deletions(-)
>>>
>>> diff --git a/cmd/Kconfig b/cmd/Kconfig
>>> index 43f78a5aeb1..953e1f0ef2a 100644
>>> --- a/cmd/Kconfig
>>> +++ b/cmd/Kconfig
>>> @@ -1406,6 +1406,15 @@ config CMD_MMC_SWRITE
>>>    	  Enable support for the "mmc swrite" command to write Android sparse
>>>    	  images to eMMC.
>>>    
>>> +config MMC_SPEED_MODE_SET
>>
>> I'm wondering if we should prefix this with CMD_ maybe? It's used in
>> drivers/mmc/ though.
>>
>> Anyway, not a blocker for this.
>>
>> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
>>
>> (You forgot Mattijs's Rb from v1 BTW)
> 
> Giving it again, thank you for noticing :)
> 
> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>

Thank you both.

Re: [PATCH v2] mmc: Hide mmc speed command under mmc command

[Tom Rini]

On Mon, 02 Sep 2024 15:37:09 +0200, Marek Vasut wrote:

> The mmc speed command configuration option keeps showing up in
> Kconfig directly in 'Command line interface'. Move MMC_SPEED_MODE_SET
> under CMD_MMC to make it show up alongside the MMC command.
> 
> 

Applied to u-boot/next, thanks!

-- 
Tom