* [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
@ 2024-03-13 13:03 ` Kurt Kanzenbach
0 siblings, 0 replies; 11+ messages in thread
From: Kurt Kanzenbach @ 2024-03-13 13:03 UTC (permalink / raw)
To: Jesse Brandeburg, Tony Nguyen, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli
Cc: Sebastian Andrzej Siewior, intel-wired-lan, netdev,
Kurt Kanzenbach
The initial igc Tx timestamping implementation used only one register for
retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
multiple in-flight TX timestamps") added support for utilizing all four of
them e.g., for multiple domain support. Remove the stale comment/FIXME.
Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
---
drivers/net/ethernet/intel/igc/igc_main.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 2e1cfbd82f4f..35ad40a803cb 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -1642,10 +1642,6 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb,
if (unlikely(test_bit(IGC_RING_FLAG_TX_HWTSTAMP, &tx_ring->flags) &&
skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {
- /* FIXME: add support for retrieving timestamps from
- * the other timer registers before skipping the
- * timestamping request.
- */
unsigned long flags;
u32 tstamp_flags;
---
base-commit: 67072c314f5f0ec12a7a51a19f7156eebb073654
change-id: 20240313-igc_txts_comment-81629dfc8b8a
Best regards,
--
Kurt Kanzenbach <kurt@linutronix.de>
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
2024-03-13 13:03 ` Kurt Kanzenbach
@ 2024-03-13 16:23 ` Vinicius Costa Gomes
-1 siblings, 0 replies; 11+ messages in thread
From: Vinicius Costa Gomes @ 2024-03-13 16:23 UTC (permalink / raw)
To: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Muhammad Husaini Zulkifli
Cc: netdev, Sebastian Andrzej Siewior, Kurt Kanzenbach,
intel-wired-lan
Kurt Kanzenbach <kurt@linutronix.de> writes:
> The initial igc Tx timestamping implementation used only one register for
> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> multiple in-flight TX timestamps") added support for utilizing all four of
> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
Ugh, sorry for forgetting about that.
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
@ 2024-03-13 16:23 ` Vinicius Costa Gomes
0 siblings, 0 replies; 11+ messages in thread
From: Vinicius Costa Gomes @ 2024-03-13 16:23 UTC (permalink / raw)
To: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Muhammad Husaini Zulkifli
Cc: Sebastian Andrzej Siewior, intel-wired-lan, netdev,
Kurt Kanzenbach
Kurt Kanzenbach <kurt@linutronix.de> writes:
> The initial igc Tx timestamping implementation used only one register for
> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> multiple in-flight TX timestamps") added support for utilizing all four of
> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
Ugh, sorry for forgetting about that.
Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cheers,
--
Vinicius
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
2024-03-13 13:03 ` Kurt Kanzenbach
@ 2024-03-14 10:21 ` Przemek Kitszel
-1 siblings, 0 replies; 11+ messages in thread
From: Przemek Kitszel @ 2024-03-14 10:21 UTC (permalink / raw)
To: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli
Cc: netdev, Sebastian Andrzej Siewior, intel-wired-lan
On 3/13/24 14:03, Kurt Kanzenbach wrote:
> The initial igc Tx timestamping implementation used only one register for
> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> multiple in-flight TX timestamps") added support for utilizing all four of
> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
I would remove fixes tag (but keep the mention in commit msg).
And I would also target it to iwl-next when the window will open.
Rationale: it's really not a fix.
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 2e1cfbd82f4f..35ad40a803cb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1642,10 +1642,6 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb,
>
> if (unlikely(test_bit(IGC_RING_FLAG_TX_HWTSTAMP, &tx_ring->flags) &&
> skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {
> - /* FIXME: add support for retrieving timestamps from
> - * the other timer registers before skipping the
> - * timestamping request.
> - */
> unsigned long flags;
> u32 tstamp_flags;
>
>
> ---
> base-commit: 67072c314f5f0ec12a7a51a19f7156eebb073654
> change-id: 20240313-igc_txts_comment-81629dfc8b8a
>
> Best regards,
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
@ 2024-03-14 10:21 ` Przemek Kitszel
0 siblings, 0 replies; 11+ messages in thread
From: Przemek Kitszel @ 2024-03-14 10:21 UTC (permalink / raw)
To: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli
Cc: Sebastian Andrzej Siewior, intel-wired-lan, netdev
On 3/13/24 14:03, Kurt Kanzenbach wrote:
> The initial igc Tx timestamping implementation used only one register for
> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> multiple in-flight TX timestamps") added support for utilizing all four of
> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
I would remove fixes tag (but keep the mention in commit msg).
And I would also target it to iwl-next when the window will open.
Rationale: it's really not a fix.
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
> index 2e1cfbd82f4f..35ad40a803cb 100644
> --- a/drivers/net/ethernet/intel/igc/igc_main.c
> +++ b/drivers/net/ethernet/intel/igc/igc_main.c
> @@ -1642,10 +1642,6 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb,
>
> if (unlikely(test_bit(IGC_RING_FLAG_TX_HWTSTAMP, &tx_ring->flags) &&
> skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) {
> - /* FIXME: add support for retrieving timestamps from
> - * the other timer registers before skipping the
> - * timestamping request.
> - */
> unsigned long flags;
> u32 tstamp_flags;
>
>
> ---
> base-commit: 67072c314f5f0ec12a7a51a19f7156eebb073654
> change-id: 20240313-igc_txts_comment-81629dfc8b8a
>
> Best regards,
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
2024-03-14 10:21 ` Przemek Kitszel
@ 2024-03-14 10:35 ` Sebastian Andrzej Siewior
-1 siblings, 0 replies; 11+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-03-14 10:35 UTC (permalink / raw)
To: Przemek Kitszel
Cc: Muhammad Husaini Zulkifli, Vinicius Costa Gomes, Vladimir Oltean,
Kurt Kanzenbach, Eric Dumazet, netdev, Tony Nguyen,
intel-wired-lan, Jakub Kicinski, Paolo Abeni, David S. Miller
On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
> On 3/13/24 14:03, Kurt Kanzenbach wrote:
> > The initial igc Tx timestamping implementation used only one register for
> > retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> > multiple in-flight TX timestamps") added support for utilizing all four of
> > them e.g., for multiple domain support. Remove the stale comment/FIXME.
> >
> > Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>
> I would remove fixes tag (but keep the mention in commit msg).
> And I would also target it to iwl-next when the window will open.
>
> Rationale: it's really not a fix.
It is a fix as it removes something that is not accurate. But it only
changes a comment so it has not outcome in the binary. I think what you
mean is that you wish that it will not be backported stable. Still
people reading the code of a v6.6 kernel might get confused.
Sebastian
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
@ 2024-03-14 10:35 ` Sebastian Andrzej Siewior
0 siblings, 0 replies; 11+ messages in thread
From: Sebastian Andrzej Siewior @ 2024-03-14 10:35 UTC (permalink / raw)
To: Przemek Kitszel
Cc: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli, intel-wired-lan,
netdev
On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
> On 3/13/24 14:03, Kurt Kanzenbach wrote:
> > The initial igc Tx timestamping implementation used only one register for
> > retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> > multiple in-flight TX timestamps") added support for utilizing all four of
> > them e.g., for multiple domain support. Remove the stale comment/FIXME.
> >
> > Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>
> I would remove fixes tag (but keep the mention in commit msg).
> And I would also target it to iwl-next when the window will open.
>
> Rationale: it's really not a fix.
It is a fix as it removes something that is not accurate. But it only
changes a comment so it has not outcome in the binary. I think what you
mean is that you wish that it will not be backported stable. Still
people reading the code of a v6.6 kernel might get confused.
Sebastian
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
2024-03-14 10:35 ` Sebastian Andrzej Siewior
@ 2024-03-15 7:22 ` Przemek Kitszel
-1 siblings, 0 replies; 11+ messages in thread
From: Przemek Kitszel @ 2024-03-15 7:22 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Muhammad Husaini Zulkifli, Vinicius Costa Gomes, Vladimir Oltean,
Kurt Kanzenbach, Eric Dumazet, netdev, Tony Nguyen,
intel-wired-lan, Jakub Kicinski, Paolo Abeni, David S. Miller
On 3/14/24 11:35, Sebastian Andrzej Siewior wrote:
> On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
>> On 3/13/24 14:03, Kurt Kanzenbach wrote:
>>> The initial igc Tx timestamping implementation used only one register for
>>> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
>>> multiple in-flight TX timestamps") added support for utilizing all four of
>>> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>>>
>>> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>>
>> I would remove fixes tag (but keep the mention in commit msg).
>> And I would also target it to iwl-next when the window will open.
>>
>> Rationale: it's really not a fix.
>
> It is a fix as it removes something that is not accurate. But it only
> changes a comment so it has not outcome in the binary. I think what you
> mean is that you wish that it will not be backported stable. Still
> people reading the code of a v6.6 kernel might get confused.
>
> Sebastian
>
You are right that this will cause no harm to backport it as is too,
I'm fine with that after a second though, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
@ 2024-03-15 7:22 ` Przemek Kitszel
0 siblings, 0 replies; 11+ messages in thread
From: Przemek Kitszel @ 2024-03-15 7:22 UTC (permalink / raw)
To: Sebastian Andrzej Siewior
Cc: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli, intel-wired-lan,
netdev
On 3/14/24 11:35, Sebastian Andrzej Siewior wrote:
> On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote:
>> On 3/13/24 14:03, Kurt Kanzenbach wrote:
>>> The initial igc Tx timestamping implementation used only one register for
>>> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
>>> multiple in-flight TX timestamps") added support for utilizing all four of
>>> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>>>
>>> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
>>
>> I would remove fixes tag (but keep the mention in commit msg).
>> And I would also target it to iwl-next when the window will open.
>>
>> Rationale: it's really not a fix.
>
> It is a fix as it removes something that is not accurate. But it only
> changes a comment so it has not outcome in the binary. I think what you
> mean is that you wish that it will not be backported stable. Still
> people reading the code of a v6.6 kernel might get confused.
>
> Sebastian
>
You are right that this will cause no harm to backport it as is too,
I'm fine with that after a second though, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping
2024-03-13 13:03 ` Kurt Kanzenbach
` (2 preceding siblings ...)
(?)
@ 2024-03-20 11:19 ` naamax.meir
-1 siblings, 0 replies; 11+ messages in thread
From: naamax.meir @ 2024-03-20 11:19 UTC (permalink / raw)
To: Kurt Kanzenbach, Jesse Brandeburg, Tony Nguyen, David S. Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean,
Vinicius Costa Gomes, Muhammad Husaini Zulkifli
Cc: netdev, Sebastian Andrzej Siewior, intel-wired-lan
On 3/13/2024 15:03, Kurt Kanzenbach wrote:
> The initial igc Tx timestamping implementation used only one register for
> retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for
> multiple in-flight TX timestamps") added support for utilizing all four of
> them e.g., for multiple domain support. Remove the stale comment/FIXME.
>
> Fixes: 3ed247e78911 ("igc: Add support for multiple in-flight TX timestamps")
> Signed-off-by: Kurt Kanzenbach <kurt@linutronix.de>
> ---
> drivers/net/ethernet/intel/igc/igc_main.c | 4 ----
> 1 file changed, 4 deletions(-)
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread