From: Markus Armbruster <armbru@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>
Subject: Re: [PATCH v2] string-output-visitor: show structs as "<omitted>"
Date: Tue, 19 Dec 2023 15:48:36 +0100 [thread overview]
Message-ID: <87v88ujliz.fsf@pond.sub.org> (raw)
In-Reply-To: <20231212134934.500289-1-stefanha@redhat.com> (Stefan Hajnoczi's message of "Tue, 12 Dec 2023 08:49:34 -0500")
Stefan Hajnoczi <stefanha@redhat.com> writes:
> StringOutputVisitor crashes when it visits a struct because
> ->start_struct() is NULL.
>
> Show "<omitted>" instead of crashing. This is necessary because the
> virtio-blk-pci iothread-vq-mapping parameter that I'd like to introduce
> soon is a list of IOThreadMapping structs.
>
> This patch is a quick fix to solve the crash, but the long-term solution
> is replacing StringOutputVisitor with something that can handle the full
> gamut of values in QEMU.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Okay as a stopgap to unblock your virtio-blk-pci work. Suggest you
merge this patch together with the patch that needs it.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2023-12-19 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:49 [PATCH v2] string-output-visitor: show structs as "<omitted>" Stefan Hajnoczi
2023-12-19 14:48 ` Markus Armbruster [this message]
2023-12-19 15:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v88ujliz.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.