All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Cc: <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>,
	 P Praneesh <quic_ppranees@quicinc.com>
Subject: Re: [PATCH 06/13] wifi: ath12k: Add logic to write QRTR node id to scratch
Date: Thu, 02 Nov 2023 17:33:22 +0200	[thread overview]
Message-ID: <87v8akuq4d.fsf@kernel.org> (raw)
In-Reply-To: <20231030222700.18914-7-quic_rajkbhag@quicinc.com> (Raj Kumar Bhagat's message of "Tue, 31 Oct 2023 03:56:53 +0530")

Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:

> From: P Praneesh <quic_ppranees@quicinc.com>
>
> Currently only one MHI device is registered successfully on platform
> having two or more identical MHI devices. This is beacuse QMI service
> runs with identical QRTR node ID. And, qrtr-lookup cannot register
> more than one QMI service with identical node ID.
>
> Hence, generate a unique QRTR instance ID from PCIe domain number and
> bus number. QMI allows node id to be written on scratch register.
> Add logic to write QRTR node id to the register. It is available for
> firmware to uniquely identify an instance.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>

BTW we got a test report that this breaks WCN7850 support.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

-- 
ath12k mailing list
ath12k@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/ath12k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
	P Praneesh <quic_ppranees@quicinc.com>
Subject: Re: [PATCH 06/13] wifi: ath12k: Add logic to write QRTR node id to scratch
Date: Thu, 02 Nov 2023 17:33:22 +0200	[thread overview]
Message-ID: <87v8akuq4d.fsf@kernel.org> (raw)
In-Reply-To: <20231030222700.18914-7-quic_rajkbhag@quicinc.com> (Raj Kumar Bhagat's message of "Tue, 31 Oct 2023 03:56:53 +0530")

Raj Kumar Bhagat <quic_rajkbhag@quicinc.com> writes:

> From: P Praneesh <quic_ppranees@quicinc.com>
>
> Currently only one MHI device is registered successfully on platform
> having two or more identical MHI devices. This is beacuse QMI service
> runs with identical QRTR node ID. And, qrtr-lookup cannot register
> more than one QMI service with identical node ID.
>
> Hence, generate a unique QRTR instance ID from PCIe domain number and
> bus number. QMI allows node id to be written on scratch register.
> Add logic to write QRTR node id to the register. It is available for
> firmware to uniquely identify an instance.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>
> Signed-off-by: P Praneesh <quic_ppranees@quicinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>

BTW we got a test report that this breaks WCN7850 support.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2023-11-02 15:33 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30 22:26 [PATCH 00/13] wifi: ath12k: QCN9274 dualmac bring up Raj Kumar Bhagat
2023-10-30 22:26 ` Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 01/13] wifi: ath12k: Update enum wmi_direct_buffer_module Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 22:43   ` Jeff Johnson
2023-10-30 22:43     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 02/13] wifi: ath12k: indicate NON MBSSID vdev by default during vdev start Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:12   ` Jeff Johnson
2023-10-30 23:12     ` Jeff Johnson
2024-01-05 18:35     ` Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 03/13] wifi: ath12k: fetch correct pdev id from WMI_SERVICE_READY_EXT_EVENTID Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:14   ` Jeff Johnson
2023-10-30 23:14     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 04/13] wifi: ath12k: add support for peer meta data version Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:16   ` Jeff Johnson
2023-10-30 23:16     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 05/13] wifi: ath12k: fix fetching MCBC flag for QCN9274 Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:17   ` Jeff Johnson
2023-10-30 23:17     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 06/13] wifi: ath12k: Add logic to write QRTR node id to scratch Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:18   ` Jeff Johnson
2023-10-30 23:18     ` Jeff Johnson
2023-11-02 15:33   ` Kalle Valo [this message]
2023-11-02 15:33     ` Kalle Valo
2023-10-30 22:26 ` [PATCH 07/13] wifi: ath12k: fix firmware assert during insmod in memory segment mode Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:27   ` Jeff Johnson
2023-10-30 23:27     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 08/13] wifi: ath12k: split hal_ops to support RX TLVs word mask compaction Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:33   ` Jeff Johnson
2023-10-30 23:33     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 09/13] wifi: ath12k: remove hal_desc_sz from hw params Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-30 23:34   ` Jeff Johnson
2023-10-30 23:34     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 10/13] wifi: ath12k: subscribe required word mask from rx tlv Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-31  0:53   ` Jeff Johnson
2023-10-31  0:53     ` Jeff Johnson
2024-01-05 18:42     ` Raj Kumar Bhagat
2023-10-30 22:26 ` [PATCH 11/13] wifi: ath12k: add MAC id support in WBM error path Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-31  1:01   ` Jeff Johnson
2023-10-31  1:01     ` Jeff Johnson
2023-10-30 22:26 ` [PATCH 12/13] wifi: ath12k: fix PCI read and write Raj Kumar Bhagat
2023-10-30 22:26   ` Raj Kumar Bhagat
2023-10-31  1:04   ` Jeff Johnson
2023-10-31  1:04     ` Jeff Johnson
2023-10-30 22:27 ` [PATCH 13/13] wifi: ath12k: Read board id to support split-PHY QCN9274 Raj Kumar Bhagat
2023-10-30 22:27   ` Raj Kumar Bhagat
2023-10-31  1:06   ` Jeff Johnson
2023-10-31  1:06     ` Jeff Johnson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8akuq4d.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_ppranees@quicinc.com \
    --cc=quic_rajkbhag@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.