From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [PATCH] audio/ossaudio: Fix compiler warning with -Wshadow
Date: Wed, 04 Oct 2023 12:43:47 +0200 [thread overview]
Message-ID: <87v8bmis64.fsf@pond.sub.org> (raw)
In-Reply-To: <20231004083900.95856-1-thuth@redhat.com> (Thomas Huth's message of "Wed, 4 Oct 2023 10:39:00 +0200")
Thomas Huth <thuth@redhat.com> writes:
> The "err" variable is only used twice in this code, in a very
> local fashion of first assigning it and then checking it in the
> next line. So there is no need to declare this variable a second
> time in the innermost block, we can re-use the variable that is
> declared at the beginning of the function. This fixes the compiler
> warning that occurs with "-Wshadow".
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Queued. Thanks!
prev parent reply other threads:[~2023-10-04 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 8:39 [PATCH] audio/ossaudio: Fix compiler warning with -Wshadow Thomas Huth
2023-10-04 8:55 ` Philippe Mathieu-Daudé
2023-10-04 10:43 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8bmis64.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.