* [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
@ 2023-09-14 13:14 Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Jani Nikula @ 2023-09-14 13:14 UTC (permalink / raw)
To: dri-devel
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, jani.nikula,
Jernej Skrabec, Laurent Pinchart, Andrzej Hajda
Make drm_bridge_get_edid() the one place to call the hook.
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_bridge_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
index 1da93d5a1f61..31baf1f5ff81 100644
--- a/drivers/gpu/drm/drm_bridge_connector.c
+++ b/drivers/gpu/drm/drm_bridge_connector.c
@@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
if (status != connector_status_connected)
goto no_edid;
- edid = bridge->funcs->get_edid(bridge, connector);
+ edid = drm_bridge_get_edid(bridge, connector);
if (!drm_edid_is_valid(edid)) {
kfree(edid);
goto no_edid;
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
@ 2023-09-14 13:14 ` Jani Nikula
2023-09-27 11:30 ` Laurent Pinchart
2023-09-26 9:56 ` [PATCH 1/2] drm/bridge: " Jani Nikula
2023-09-26 10:19 ` Laurent Pinchart
2 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2023-09-14 13:14 UTC (permalink / raw)
To: dri-devel
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, jani.nikula,
Jernej Skrabec, Laurent Pinchart, Andrzej Hajda
Make drm_bridge_get_edid() the one place to call the hook.
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Robert Foss <rfoss@kernel.org>
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
UNTESTED
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 22c84d29c2bc..7835738a532e 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
unsigned int count;
struct edid *edid;
- edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
+ edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
drm_connector_update_edid_property(connector, edid);
count = drm_add_edid_modes(connector, edid);
kfree(edid);
--
2.39.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
@ 2023-09-26 9:56 ` Jani Nikula
2023-09-26 10:19 ` Laurent Pinchart
2 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2023-09-26 9:56 UTC (permalink / raw)
To: dri-devel
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
Laurent Pinchart, Andrzej Hajda
Ping?
On Thu, 14 Sep 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 1da93d5a1f61..31baf1f5ff81 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
> if (status != connector_status_connected)
> goto no_edid;
>
> - edid = bridge->funcs->get_edid(bridge, connector);
> + edid = drm_bridge_get_edid(bridge, connector);
> if (!drm_edid_is_valid(edid)) {
> kfree(edid);
> goto no_edid;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
2023-09-26 9:56 ` [PATCH 1/2] drm/bridge: " Jani Nikula
@ 2023-09-26 10:19 ` Laurent Pinchart
2023-09-27 10:33 ` Jani Nikula
2 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2023-09-26 10:19 UTC (permalink / raw)
To: Jani Nikula
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
Hi Jani,
Thank you for the patch.
On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> index 1da93d5a1f61..31baf1f5ff81 100644
> --- a/drivers/gpu/drm/drm_bridge_connector.c
> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
> if (status != connector_status_connected)
> goto no_edid;
>
> - edid = bridge->funcs->get_edid(bridge, connector);
> + edid = drm_bridge_get_edid(bridge, connector);
> if (!drm_edid_is_valid(edid)) {
> kfree(edid);
> goto no_edid;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-26 10:19 ` Laurent Pinchart
@ 2023-09-27 10:33 ` Jani Nikula
2023-09-27 11:31 ` Laurent Pinchart
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2023-09-27 10:33 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
On Tue, 26 Sep 2023, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Jani,
>
> Thank you for the patch.
>
> On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote:
>> Make drm_bridge_get_edid() the one place to call the hook.
>>
>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: Jonas Karlman <jonas@kwiboo.se>
>> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thanks Laurent, does that cover patch 2/2 as well, or just 1/2?
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
>> index 1da93d5a1f61..31baf1f5ff81 100644
>> --- a/drivers/gpu/drm/drm_bridge_connector.c
>> +++ b/drivers/gpu/drm/drm_bridge_connector.c
>> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
>> if (status != connector_status_connected)
>> goto no_edid;
>>
>> - edid = bridge->funcs->get_edid(bridge, connector);
>> + edid = drm_bridge_get_edid(bridge, connector);
>> if (!drm_edid_is_valid(edid)) {
>> kfree(edid);
>> goto no_edid;
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
@ 2023-09-27 11:30 ` Laurent Pinchart
2023-09-27 14:09 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2023-09-27 11:30 UTC (permalink / raw)
To: Jani Nikula
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
Hi Jani,
On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
> Make drm_bridge_get_edid() the one place to call the hook.
>
> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> Cc: Robert Foss <rfoss@kernel.org>
> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> Cc: Jonas Karlman <jonas@kwiboo.se>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> UNTESTED
I can't test this either, but it looks fine.
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 22c84d29c2bc..7835738a532e 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
> unsigned int count;
> struct edid *edid;
>
> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
> drm_connector_update_edid_property(connector, edid);
> count = drm_add_edid_modes(connector, edid);
> kfree(edid);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-27 10:33 ` Jani Nikula
@ 2023-09-27 11:31 ` Laurent Pinchart
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Pinchart @ 2023-09-27 11:31 UTC (permalink / raw)
To: Jani Nikula
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
On Wed, Sep 27, 2023 at 01:33:56PM +0300, Jani Nikula wrote:
> On Tue, 26 Sep 2023, Laurent Pinchart wrote:
> > On Thu, Sep 14, 2023 at 04:14:49PM +0300, Jani Nikula wrote:
> >> Make drm_bridge_get_edid() the one place to call the hook.
> >>
> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> >> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> >> Cc: Robert Foss <rfoss@kernel.org>
> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> >> Cc: Jonas Karlman <jonas@kwiboo.se>
> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>
> Thanks Laurent, does that cover patch 2/2 as well, or just 1/2?
Just 1/2, I hadn't looked at 2/2. I've now reviewed it too.
> >> ---
> >> drivers/gpu/drm/drm_bridge_connector.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/drm_bridge_connector.c b/drivers/gpu/drm/drm_bridge_connector.c
> >> index 1da93d5a1f61..31baf1f5ff81 100644
> >> --- a/drivers/gpu/drm/drm_bridge_connector.c
> >> +++ b/drivers/gpu/drm/drm_bridge_connector.c
> >> @@ -238,7 +238,7 @@ static int drm_bridge_connector_get_modes_edid(struct drm_connector *connector,
> >> if (status != connector_status_connected)
> >> goto no_edid;
> >>
> >> - edid = bridge->funcs->get_edid(bridge, connector);
> >> + edid = drm_bridge_get_edid(bridge, connector);
> >> if (!drm_edid_is_valid(edid)) {
> >> kfree(edid);
> >> goto no_edid;
>
> --
> Jani Nikula, Intel
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-27 11:30 ` Laurent Pinchart
@ 2023-09-27 14:09 ` Jani Nikula
2023-09-27 22:35 ` Laurent Pinchart
0 siblings, 1 reply; 10+ messages in thread
From: Jani Nikula @ 2023-09-27 14:09 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
On Wed, 27 Sep 2023, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> Hi Jani,
>
> On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
>> Make drm_bridge_get_edid() the one place to call the hook.
>>
>> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> Cc: Robert Foss <rfoss@kernel.org>
>> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> Cc: Jonas Karlman <jonas@kwiboo.se>
>> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> UNTESTED
>
> I can't test this either, but it looks fine.
Thanks. Are you okay with merging the two with review only?
BR,
Jani.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
>> ---
>> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> index 22c84d29c2bc..7835738a532e 100644
>> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
>> unsigned int count;
>> struct edid *edid;
>>
>> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
>> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
>> drm_connector_update_edid_property(connector, edid);
>> count = drm_add_edid_modes(connector, edid);
>> kfree(edid);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-27 14:09 ` Jani Nikula
@ 2023-09-27 22:35 ` Laurent Pinchart
2023-09-29 11:27 ` Jani Nikula
0 siblings, 1 reply; 10+ messages in thread
From: Laurent Pinchart @ 2023-09-27 22:35 UTC (permalink / raw)
To: Jani Nikula
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
On Wed, Sep 27, 2023 at 05:09:23PM +0300, Jani Nikula wrote:
> On Wed, 27 Sep 2023, Laurent Pinchart wrote:
> > On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
> >> Make drm_bridge_get_edid() the one place to call the hook.
> >>
> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
> >> Cc: Neil Armstrong <neil.armstrong@linaro.org>
> >> Cc: Robert Foss <rfoss@kernel.org>
> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
> >> Cc: Jonas Karlman <jonas@kwiboo.se>
> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> >>
> >> ---
> >>
> >> UNTESTED
> >
> > I can't test this either, but it looks fine.
>
> Thanks. Are you okay with merging the two with review only?
The changes are trivial, if we can't get anyone to test them, then I'm
OK merging them.
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> >> ---
> >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> index 22c84d29c2bc..7835738a532e 100644
> >> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> >> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
> >> unsigned int count;
> >> struct edid *edid;
> >>
> >> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
> >> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
> >> drm_connector_update_edid_property(connector, edid);
> >> count = drm_add_edid_modes(connector, edid);
> >> kfree(edid);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] drm/bridge: lt9611uxc: use drm_bridge_get_edid() instead of using ->get_edid directly
2023-09-27 22:35 ` Laurent Pinchart
@ 2023-09-29 11:27 ` Jani Nikula
0 siblings, 0 replies; 10+ messages in thread
From: Jani Nikula @ 2023-09-29 11:27 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Neil Armstrong, Robert Foss, Jonas Karlman, Jernej Skrabec,
dri-devel, Andrzej Hajda
On Thu, 28 Sep 2023, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> On Wed, Sep 27, 2023 at 05:09:23PM +0300, Jani Nikula wrote:
>> On Wed, 27 Sep 2023, Laurent Pinchart wrote:
>> > On Thu, Sep 14, 2023 at 04:14:50PM +0300, Jani Nikula wrote:
>> >> Make drm_bridge_get_edid() the one place to call the hook.
>> >>
>> >> Cc: Andrzej Hajda <andrzej.hajda@intel.com>
>> >> Cc: Neil Armstrong <neil.armstrong@linaro.org>
>> >> Cc: Robert Foss <rfoss@kernel.org>
>> >> Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
>> >> Cc: Jonas Karlman <jonas@kwiboo.se>
>> >> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
>> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> >>
>> >> ---
>> >>
>> >> UNTESTED
>> >
>> > I can't test this either, but it looks fine.
>>
>> Thanks. Are you okay with merging the two with review only?
>
> The changes are trivial, if we can't get anyone to test them, then I'm
> OK merging them.
Thanks, pushed to drm-misc-next.
BR,
Jani.
>
>> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> >
>> >> ---
>> >> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
>> >> 1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> >> index 22c84d29c2bc..7835738a532e 100644
>> >> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> >> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
>> >> @@ -296,7 +296,7 @@ static int lt9611uxc_connector_get_modes(struct drm_connector *connector)
>> >> unsigned int count;
>> >> struct edid *edid;
>> >>
>> >> - edid = lt9611uxc->bridge.funcs->get_edid(<9611uxc->bridge, connector);
>> >> + edid = drm_bridge_get_edid(<9611uxc->bridge, connector);
>> >> drm_connector_update_edid_property(connector, edid);
>> >> count = drm_add_edid_modes(connector, edid);
>> >> kfree(edid);
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-09-29 11:27 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-14 13:14 [PATCH 1/2] drm/bridge: use drm_bridge_get_edid() instead of using ->get_edid directly Jani Nikula
2023-09-14 13:14 ` [PATCH 2/2] drm/bridge: lt9611uxc: " Jani Nikula
2023-09-27 11:30 ` Laurent Pinchart
2023-09-27 14:09 ` Jani Nikula
2023-09-27 22:35 ` Laurent Pinchart
2023-09-29 11:27 ` Jani Nikula
2023-09-26 9:56 ` [PATCH 1/2] drm/bridge: " Jani Nikula
2023-09-26 10:19 ` Laurent Pinchart
2023-09-27 10:33 ` Jani Nikula
2023-09-27 11:31 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.