Re: [PATCH 3/4] drm/ast: Rename struct ast_private to struct ast_device

[Javier Martinez Canillas <javierm@redhat.com>]

Thomas Zimmermann <tzimmermann@suse.de> writes:

> The data structure struct ast_private represents an AST device. Its
> name comes from the time when it was allocated and stored separately
> in struct drm_device.dev_private. The DRM device is now embedded, so
> rename struct ast_private to struct ast_device.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>  drivers/gpu/drm/ast/ast_dp.c    | 10 ++--
>  drivers/gpu/drm/ast/ast_dp501.c | 40 +++++++-------
>  drivers/gpu/drm/ast/ast_drv.c   |  2 +-
>  drivers/gpu/drm/ast/ast_drv.h   | 40 +++++++-------
>  drivers/gpu/drm/ast/ast_i2c.c   |  8 +--
>  drivers/gpu/drm/ast/ast_main.c  | 24 ++++-----
>  drivers/gpu/drm/ast/ast_mm.c    |  4 +-
>  drivers/gpu/drm/ast/ast_mode.c  | 78 +++++++++++++--------------
>  drivers/gpu/drm/ast/ast_post.c  | 94 ++++++++++++++++-----------------
>  9 files changed, 150 insertions(+), 150 deletions(-)
>
> diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c
> index 56483860306b..9e34297d836d 100644
> --- a/drivers/gpu/drm/ast/ast_dp.c
> +++ b/drivers/gpu/drm/ast/ast_dp.c
> @@ -9,7 +9,7 @@
>  
>  int ast_astdp_read_edid(struct drm_device *dev, u8 *ediddata)
>  {
> -	struct ast_private *ast = to_ast_private(dev);
> +	struct ast_device *ast = to_ast_private(dev);

I would just squash patches #3 and #4 and rename the macro as well. There
is no need to have it as two separate patches IMO.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat