All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	pcc@google.com, Ard Biesheuvel <ardb@kernel.org>,
	kernel-team@android.com
Subject: Re: [PATCH] arm64: Use mov_q to load KPTI_NG_PTE_FLAGS/SWAPPER_R*_MMUFLAGS
Date: Thu, 21 Jul 2022 17:10:46 +0100	[thread overview]
Message-ID: <87v8rqxx89.wl-maz@kernel.org> (raw)
In-Reply-To: <YtlvEw24qyundr0D@arm.com>

On Thu, 21 Jul 2022 16:21:55 +0100,
Catalin Marinas <catalin.marinas@arm.com> wrote:
> 
> On Thu, Jul 21, 2022 at 01:42:44PM +0100, Marc Zyngier wrote:
> > With f7b4c3b82e7d ("arm64: set UXN on swapper page tables"),
> > the kernel fails to build:
> > 
> > arch/arm64/kernel/head.S: Assembler messages:
> > arch/arm64/kernel/head.S:334: Error: immediate cannot be moved by a single instruction
> > arch/arm64/kernel/head.S:343: Error: immediate cannot be moved by a single instruction
> > arch/arm64/kernel/head.S:354: Error: immediate cannot be moved by a single instruction
> > arch/arm64/kernel/head.S:379: Error: immediate cannot be moved by a single instruction
> > 
> > as the constants that inherit SWAPPER_P*_FLAGS cannot be loaded
> > using a single 'mov' instruction. Move over to mov_q to fix this.
> > 
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> 
> Thanks for the fix Marc, this only applies to -next. We could either
> revert Peter's patch [1] in -next but keep it for 5.19 or simply drop it
> from for-next/fixes and send it to stable post 5.19. I'm more inclined
> to do the latter.

Agreed, this seems like a sensible decision. This is unlikely to
affect a large user base at this stage anyway.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2022-07-21 16:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 12:42 [PATCH] arm64: Use mov_q to load KPTI_NG_PTE_FLAGS/SWAPPER_R*_MMUFLAGS Marc Zyngier
2022-07-21 15:21 ` Catalin Marinas
2022-07-21 16:10   ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8rqxx89.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kernel-team@android.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pcc@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.