From: Kalle Valo <kvalo@kernel.org>
To: Carl Huang <cjhuang@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/6] ath11k: purge rx pktlog when entering WoW
Date: Thu, 09 Dec 2021 17:12:41 +0200 [thread overview]
Message-ID: <87v8zxzuae.fsf@codeaurora.org> (raw)
In-Reply-To: <20211011193750.4891-5-cjhuang@codeaurora.org> (Carl Huang's message of "Mon, 11 Oct 2021 15:37:48 -0400")
Carl Huang <cjhuang@codeaurora.org> writes:
> This change is to purge rx pktlog when entering WoW and reap
> the mon_status buffer to keep it empty. When leaving WoW, host
> restarts the reap timer. In WoW state, it's not allowed to feed
> into mon_status rings per firmware request.
"per firmware request" is not clear for me. Do you "per firmware team's
recommendation" or what?
> @@ -327,12 +327,7 @@ int ath11k_core_resume(struct ath11k_base *ab)
> ath11k_hif_ce_irq_enable(ab);
> ath11k_hif_irq_enable(ab);
>
> - ret = ath11k_dp_rx_pktlog_start(ab);
> - if (ret) {
> - ath11k_warn(ab, "failed to start rx pktlog during resume: %d\n",
> - ret);
> - return ret;
> - }
> + ath11k_dp_rx_pktlog_start(ab);
Why remove error handling? We should always handle the errors.
>
> ret = ath11k_wow_wakeup(ab);
> if (ret) {
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 6d769ba..ae6db5d 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -5105,13 +5105,11 @@ int ath11k_dp_rx_pdev_mon_detach(struct ath11k *ar)
> return 0;
> }
>
> -int ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
> +void ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
> {
> /* start reap timer */
> mod_timer(&ab->mon_reap_timer,
> jiffies + msecs_to_jiffies(ATH11K_MON_TIMER_INTERVAL));
> -
> - return 0;
> }
Ah, you remove it here as well. But for consistency it's better to have
this return an error code.
> @@ -640,6 +657,8 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ath11k_hif_ce_irq_enable(ar->ab);
> ath11k_hif_irq_enable(ar->ab);
>
> + ath11k_dp_rx_pktlog_start(ar->ab);
Error handling here as well, please.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@kernel.org>
To: Carl Huang <cjhuang@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 4/6] ath11k: purge rx pktlog when entering WoW
Date: Thu, 09 Dec 2021 17:12:41 +0200 [thread overview]
Message-ID: <87v8zxzuae.fsf@codeaurora.org> (raw)
In-Reply-To: <20211011193750.4891-5-cjhuang@codeaurora.org> (Carl Huang's message of "Mon, 11 Oct 2021 15:37:48 -0400")
Carl Huang <cjhuang@codeaurora.org> writes:
> This change is to purge rx pktlog when entering WoW and reap
> the mon_status buffer to keep it empty. When leaving WoW, host
> restarts the reap timer. In WoW state, it's not allowed to feed
> into mon_status rings per firmware request.
"per firmware request" is not clear for me. Do you "per firmware team's
recommendation" or what?
> @@ -327,12 +327,7 @@ int ath11k_core_resume(struct ath11k_base *ab)
> ath11k_hif_ce_irq_enable(ab);
> ath11k_hif_irq_enable(ab);
>
> - ret = ath11k_dp_rx_pktlog_start(ab);
> - if (ret) {
> - ath11k_warn(ab, "failed to start rx pktlog during resume: %d\n",
> - ret);
> - return ret;
> - }
> + ath11k_dp_rx_pktlog_start(ab);
Why remove error handling? We should always handle the errors.
>
> ret = ath11k_wow_wakeup(ab);
> if (ret) {
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 6d769ba..ae6db5d 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -5105,13 +5105,11 @@ int ath11k_dp_rx_pdev_mon_detach(struct ath11k *ar)
> return 0;
> }
>
> -int ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
> +void ath11k_dp_rx_pktlog_start(struct ath11k_base *ab)
> {
> /* start reap timer */
> mod_timer(&ab->mon_reap_timer,
> jiffies + msecs_to_jiffies(ATH11K_MON_TIMER_INTERVAL));
> -
> - return 0;
> }
Ah, you remove it here as well. But for consistency it's better to have
this return an error code.
> @@ -640,6 +657,8 @@ int ath11k_wow_op_resume(struct ieee80211_hw *hw)
> ath11k_hif_ce_irq_enable(ar->ab);
> ath11k_hif_irq_enable(ar->ab);
>
> + ath11k_dp_rx_pktlog_start(ar->ab);
Error handling here as well, please.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-09 15:12 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 19:37 [PATCH 0/6] ath11k: support WoW functionalities Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-10-11 19:37 ` [PATCH 1/6] ath11k: Add basic " Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 14:48 ` Kalle Valo
2021-12-09 14:48 ` Kalle Valo
2021-10-11 19:37 ` [PATCH 2/6] ath11k: Add WoW net-detect functionality Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 14:57 ` Kalle Valo
2021-12-09 14:57 ` Kalle Valo
2021-12-09 15:03 ` Kalle Valo
2021-12-09 15:03 ` Kalle Valo
2021-10-11 19:37 ` [PATCH 3/6] ath11k: implement hw data filter Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 15:07 ` Kalle Valo
2021-12-09 15:07 ` Kalle Valo
2021-12-09 15:47 ` Kalle Valo
2021-12-09 15:47 ` Kalle Valo
2021-10-11 19:37 ` [PATCH 4/6] ath11k: purge rx pktlog when entering WoW Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 15:12 ` Kalle Valo [this message]
2021-12-09 15:12 ` Kalle Valo
2021-10-11 19:37 ` [PATCH 5/6] ath11k: support ARP and NS offload Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 15:16 ` Kalle Valo
2021-12-09 15:16 ` Kalle Valo
2021-12-09 16:07 ` Kalle Valo
2021-12-09 16:07 ` Kalle Valo
2021-10-11 19:37 ` [PATCH 6/6] ath11k: support GTK rekey offload Carl Huang
2021-10-11 19:37 ` Carl Huang
2021-12-09 16:05 ` Kalle Valo
2021-12-09 16:05 ` Kalle Valo
2021-12-17 11:04 ` Carl Huang
2021-12-17 11:04 ` Carl Huang
2021-12-18 8:37 ` Sven Eckelmann
2021-12-18 8:37 ` Sven Eckelmann
2021-12-18 8:43 ` Sven Eckelmann
2021-12-18 8:43 ` Sven Eckelmann
2021-12-18 9:16 ` Sven Eckelmann
2021-12-18 9:16 ` Sven Eckelmann
2021-12-20 10:03 ` Kalle Valo
2021-12-20 10:03 ` Kalle Valo
2021-12-20 11:50 ` Sven Eckelmann
2021-12-20 11:50 ` Sven Eckelmann
2021-12-21 14:48 ` Kalle Valo
2021-12-21 14:48 ` Kalle Valo
2021-12-21 20:39 ` Sven Eckelmann
2021-12-21 20:39 ` Sven Eckelmann
2021-12-09 17:45 ` [PATCH 0/6] ath11k: support WoW functionalities Kalle Valo
2021-12-09 17:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8zxzuae.fsf@codeaurora.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.