From: Markus Armbruster <armbru@redhat.com>
To: qemu-trivial@nongnu.org
Cc: qemu-devel@nongnu.org, jiri@resnulli.us, ehabkost@redhat.com,
groug@kaod.org, david@redhat.com, jcmvbkbc@gmail.com
Subject: Re: [PATCH] Trim some trailing space from human-readable output
Date: Mon, 25 Oct 2021 11:12:44 +0200 [thread overview]
Message-ID: <87v91lii2b.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20211009152401.2982862-1-armbru@redhat.com> (Markus Armbruster's message of "Sat, 9 Oct 2021 17:24:01 +0200")
Nominating for qemu-trivial.
Tweaking the subject to
monitor: Trim some trailing space from human-readable output
as Philippe suggested would be nice.
Markus Armbruster <armbru@redhat.com> writes:
> I noticed -cpu help printing enough trailing spaces to make the output
> at least 84 characters wide. Looks ugly unless the terminal is wider.
> Ugly or not, trailing spaces are stupid.
>
> The culprit is this line in x86_cpu_list_entry():
>
> qemu_printf("x86 %-20s %-58s\n", name, desc);
>
> This prints a string with minimum field left-justified right before a
> newline. Change it to
>
> qemu_printf("x86 %-20s %s\n", name, desc);
>
> which avoids the trailing spaces and is simpler to boot.
>
> A search for the pattern with "git-grep -E '%-[0-9]+s\\n'" found a few
> more instances. Change them similarly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: qemu-trivial@nongnu.org
Cc: jiri@resnulli.us, ehabkost@redhat.com, david@redhat.com,
groug@kaod.org, qemu-devel@nongnu.org, jcmvbkbc@gmail.com
Subject: Re: [PATCH] Trim some trailing space from human-readable output
Date: Mon, 25 Oct 2021 11:12:44 +0200 [thread overview]
Message-ID: <87v91lii2b.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <20211009152401.2982862-1-armbru@redhat.com> (Markus Armbruster's message of "Sat, 9 Oct 2021 17:24:01 +0200")
Nominating for qemu-trivial.
Tweaking the subject to
monitor: Trim some trailing space from human-readable output
as Philippe suggested would be nice.
Markus Armbruster <armbru@redhat.com> writes:
> I noticed -cpu help printing enough trailing spaces to make the output
> at least 84 characters wide. Looks ugly unless the terminal is wider.
> Ugly or not, trailing spaces are stupid.
>
> The culprit is this line in x86_cpu_list_entry():
>
> qemu_printf("x86 %-20s %-58s\n", name, desc);
>
> This prints a string with minimum field left-justified right before a
> newline. Change it to
>
> qemu_printf("x86 %-20s %s\n", name, desc);
>
> which avoids the trailing spaces and is simpler to boot.
>
> A search for the pattern with "git-grep -E '%-[0-9]+s\\n'" found a few
> more instances. Change them similarly.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
next prev parent reply other threads:[~2021-10-25 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-09 15:24 [PATCH] Trim some trailing space from human-readable output Markus Armbruster
2021-10-09 16:07 ` Richard Henderson
2021-10-11 12:33 ` Greg Kurz
2021-10-11 22:28 ` Philippe Mathieu-Daudé
2021-10-12 4:48 ` Markus Armbruster
2021-10-11 22:35 ` Max Filippov
2021-10-25 9:12 ` Markus Armbruster [this message]
2021-10-25 9:12 ` Markus Armbruster
2021-10-25 9:17 ` Laurent Vivier
2021-10-25 9:17 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v91lii2b.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=david@redhat.com \
--cc=ehabkost@redhat.com \
--cc=groug@kaod.org \
--cc=jcmvbkbc@gmail.com \
--cc=jiri@resnulli.us \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.