[PATCH 1/1] virtio-blk: fix virtqueues accounting

[PATCH 1/1] virtio-blk: fix virtqueues accounting

[Max Gurtovoy]

Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.

Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/content.tex b/content.tex
index 5c70a3c..c266fd5 100644
--- a/content.tex
+++ b/content.tex
@@ -4398,7 +4398,7 @@ \subsection{Virtqueues}\label{sec:Device Types / Block Device / Virtqueues}
 \begin{description}
 \item[0] requestq1
 \item[\ldots]
-\item[N] requestqN
+\item[N-1] requestqN
 \end{description}
 
  N=1 if VIRTIO_BLK_F_MQ is not negotiated, otherwise N is set by
-- 
2.21.0

[virtio-comment] Re: [PATCH 1/1] virtio-blk: fix virtqueues accounting

[Cornelia Huck]

On Wed, Jul 21 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:

> Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.
>
> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
> ---
>  content.tex | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

We had an issue for a similar fix for virtio-net, so do we want to use
issue+voting here as well, or would that be overkill? I'm inclined to do
this as an editorial update.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

Re: [virtio-comment] Re: [PATCH 1/1] virtio-blk: fix virtqueues accounting

[Cornelia Huck]

On Thu, Jul 22 2021, Cornelia Huck <cohuck@redhat.com> wrote:

> On Wed, Jul 21 2021, Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
>
>> Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.
>>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>  content.tex | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>
> We had an issue for a similar fix for virtio-net, so do we want to use
> issue+voting here as well, or would that be overkill? I'm inclined to do
> this as an editorial update.

I just went ahead and pushed it as an editorial update. Thanks.


This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.

Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/