Re: Let's remove some deprecated stuff

[Markus Armbruster <armbru@redhat.com>]

Daniel P. Berrangé <berrange@redhat.com> writes:

> On Thu, Apr 29, 2021 at 11:59:41AM +0200, Markus Armbruster wrote:
>> Myself, but I only documented it; it's actually Kevin Wolf:
>> 
>>     ``blockdev-open-tray``, ``blockdev-close-tray`` argument ``device`` (since 2.8.0)
>>     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
>> 
>>     Use argument ``id`` instead.
>> 
>>     ``eject`` argument ``device`` (since 2.8.0)
>>     '''''''''''''''''''''''''''''''''''''''''''
>> 
>>     Use argument ``id`` instead.
>> 
>>     ``blockdev-change-medium`` argument ``device`` (since 2.8.0)
>>     ''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
>> 
>>     Use argument ``id`` instead.
>> 
>>     ``block_set_io_throttle`` argument ``device`` (since 2.8.0)
>>     '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
>> 
>>     Use argument ``id`` instead.
>
> FYI, I did prepare patches for these already, but they broke the iotests.
>
> I found it difficult to figure out the right fix for the iotests, becuase
> IIUC "device" and "id" values are different, and I didn't see what "id"
> to use when args are still using -drive, not -blockdev.

Rebase and post as RFC to solicit clues or even fixes?

[...]