From: Kalle Valo <kvalo@codeaurora.org>
To: Evan Green <evgreen@chromium.org>
Cc: Govind Singh <govinds@qti.qualcomm.com>,
kuabhs@google.com.org, sujitka@chromium.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Michal Kazior <michal.kazior@tieto.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths
Date: Mon, 08 Jun 2020 14:38:43 +0300 [thread overview]
Message-ID: <87v9k1iy7w.fsf@codeaurora.org> (raw)
In-Reply-To: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> (Evan Green's message of "Thu, 4 Jun 2020 10:59:11 -0700")
Evan Green <evgreen@chromium.org> writes:
> ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock
> is held. Acquire the lock in a couple of error paths when calling that
> function to ensure this condition is met.
>
> Fixes: 6421969f248fd ("ath10k: refactor tx pending management")
> Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64
> descriptor")
Fixes tag should be in one line, I fixed that in the pending branch.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Evan Green <evgreen@chromium.org>
Cc: Govind Singh <govinds@qti.qualcomm.com>,
kuabhs@google.com.org, sujitka@chromium.org,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, ath10k@lists.infradead.org,
Michal Kazior <michal.kazior@tieto.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] ath10k: Acquire tx_lock in tx error paths
Date: Mon, 08 Jun 2020 14:38:43 +0300 [thread overview]
Message-ID: <87v9k1iy7w.fsf@codeaurora.org> (raw)
In-Reply-To: <20200604105901.1.I5b8b0c7ee0d3e51a73248975a9da61401b8f3900@changeid> (Evan Green's message of "Thu, 4 Jun 2020 10:59:11 -0700")
Evan Green <evgreen@chromium.org> writes:
> ath10k_htt_tx_free_msdu_id() has a lockdep assertion that htt->tx_lock
> is held. Acquire the lock in a couple of error paths when calling that
> function to ensure this condition is met.
>
> Fixes: 6421969f248fd ("ath10k: refactor tx pending management")
> Fixes: e62ee5c381c59 ("ath10k: Add support for htt_data_tx_desc_64
> descriptor")
Fixes tag should be in one line, I fixed that in the pending branch.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-06-08 11:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:59 [PATCH] ath10k: Acquire tx_lock in tx error paths Evan Green
2020-06-04 17:59 ` Evan Green
2020-06-08 11:38 ` Kalle Valo [this message]
2020-06-08 11:38 ` Kalle Valo
2020-06-08 16:07 ` Evan Green
2020-06-08 16:07 ` Evan Green
2020-06-09 6:23 ` Kalle Valo
2020-06-09 6:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9k1iy7w.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=evgreen@chromium.org \
--cc=govinds@qti.qualcomm.com \
--cc=kuabhs@google.com.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
--cc=netdev@vger.kernel.org \
--cc=sujitka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.