From: Florian Weimer <fw@deneb.enyo.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 13:23:53 +0200 [thread overview]
Message-ID: <87v9luwgc6.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAFEAcA9Gep1HN+7WJHencp9g2uUBLhagxdgjHf-16AOdP5oOjg@mail.gmail.com> (Peter Maydell's message of "Mon, 20 Apr 2020 12:19:17 +0100")
* Peter Maydell:
> We open fd 3 to read '.'; we issue the new fcntl, which
> succeeds. Then there's some unrelated stuff operating on
> stdout. Then we do a getdents64(), but the d_off values
> we get back are still 64 bits. The guest binary doesn't
> like those, so it fails. My expectation was that we would
> get back d_off values here that were in the 32 bit range.
What's your file system?
I think not all of them have 32-bit hashes (some of them probably
can't, particularly in the network-based file system case).
WARNING: multiple messages have this Message-ID (diff)
From: Florian Weimer <fw@deneb.enyo.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
Linux API <linux-api@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Andy Lutomirski <luto@kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] fcntl: Add 32bit filesystem mode
Date: Mon, 20 Apr 2020 13:23:53 +0200 [thread overview]
Message-ID: <87v9luwgc6.fsf@mid.deneb.enyo.de> (raw)
In-Reply-To: <CAFEAcA9Gep1HN+7WJHencp9g2uUBLhagxdgjHf-16AOdP5oOjg@mail.gmail.com> (Peter Maydell's message of "Mon, 20 Apr 2020 12:19:17 +0100")
* Peter Maydell:
> We open fd 3 to read '.'; we issue the new fcntl, which
> succeeds. Then there's some unrelated stuff operating on
> stdout. Then we do a getdents64(), but the d_off values
> we get back are still 64 bits. The guest binary doesn't
> like those, so it fails. My expectation was that we would
> get back d_off values here that were in the 32 bit range.
What's your file system?
I think not all of them have 32-bit hashes (some of them probably
can't, particularly in the network-based file system case).
next prev parent reply other threads:[~2020-04-20 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 13:35 [PATCH] fcntl: Add 32bit filesystem mode Linus Walleij
2020-03-31 13:35 ` Linus Walleij
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:19 ` Peter Maydell
2020-04-20 11:23 ` Florian Weimer [this message]
2020-04-20 11:23 ` Florian Weimer
2020-04-20 11:38 ` Peter Maydell
2020-04-20 11:38 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 14:16 ` Peter Maydell
2020-04-20 23:51 ` Andreas Dilger
2020-04-20 23:51 ` Andreas Dilger
2020-04-21 13:02 ` Peter Maydell
2020-04-21 13:02 ` Peter Maydell
2020-04-20 15:13 ` Theodore Y. Ts'o
2020-04-20 15:13 ` Theodore Y. Ts'o
2020-04-20 15:23 ` Eric Blake
2020-04-20 15:29 ` Peter Maydell
2020-04-20 15:29 ` Peter Maydell
2020-04-20 17:01 ` Theodore Y. Ts'o
2020-04-20 17:01 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9luwgc6.fsf@mid.deneb.enyo.de \
--to=fw@deneb.enyo.de \
--cc=adilger.kernel@dilger.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.