From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: akpm@linux-foundation.org, peterz@infradead.org, will@kernel.org,
mpe@ellerman.id.au, davem@davemloft.net
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 6/9] asm-generic/tlb: Rename HAVE_RCU_TABLE_FREE
Date: Sat, 18 Jan 2020 11:26:40 +0530 [thread overview]
Message-ID: <87v9p9mhnr.fsf@linux.ibm.com> (raw)
In-Reply-To: <20200116064531.483522-7-aneesh.kumar@linux.ibm.com>
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> From: Peter Zijlstra <peterz@infradead.org>
>
> Towards a more consistent naming scheme.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
...
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index 18e9fb6fcf1b..c703eb6b7461 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -64,7 +64,7 @@ config SPARC64
> select HAVE_FUNCTION_GRAPH_TRACER
> select HAVE_KRETPROBES
> select HAVE_KPROBES
> - select HAVE_RCU_TABLE_FREE if SMP
> + select MMU_GATHER_RCU_TABLE_FREE
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> select HAVE_DYNAMIC_FTRACE
This resulted in build failure reported by kbuild test robot. Can we
fold the below change
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index c703eb6b7461..02907584be2d 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -64,7 +64,7 @@ config SPARC64
select HAVE_FUNCTION_GRAPH_TRACER
select HAVE_KRETPROBES
select HAVE_KPROBES
- select MMU_GATHER_RCU_TABLE_FREE
+ select MMU_GATHER_RCU_TABLE_FREE if SMP
select HAVE_MEMBLOCK_NODE_MAP
select HAVE_ARCH_TRANSPARENT_HUGEPAGE
select HAVE_DYNAMIC_FTRACE
We should handle that drop of SMP in a separate patch if needed.
-aneesh
WARNING: multiple messages have this Message-ID (diff)
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: akpm@linux-foundation.org, peterz@infradead.org, will@kernel.org,
mpe@ellerman.id.au, davem@davemloft.net
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 6/9] asm-generic/tlb: Rename HAVE_RCU_TABLE_FREE
Date: Sat, 18 Jan 2020 11:26:40 +0530 [thread overview]
Message-ID: <87v9p9mhnr.fsf@linux.ibm.com> (raw)
In-Reply-To: <20200116064531.483522-7-aneesh.kumar@linux.ibm.com>
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> writes:
> From: Peter Zijlstra <peterz@infradead.org>
>
> Towards a more consistent naming scheme.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
...
> diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
> index 18e9fb6fcf1b..c703eb6b7461 100644
> --- a/arch/sparc/Kconfig
> +++ b/arch/sparc/Kconfig
> @@ -64,7 +64,7 @@ config SPARC64
> select HAVE_FUNCTION_GRAPH_TRACER
> select HAVE_KRETPROBES
> select HAVE_KPROBES
> - select HAVE_RCU_TABLE_FREE if SMP
> + select MMU_GATHER_RCU_TABLE_FREE
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> select HAVE_DYNAMIC_FTRACE
This resulted in build failure reported by kbuild test robot. Can we
fold the below change
diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig
index c703eb6b7461..02907584be2d 100644
--- a/arch/sparc/Kconfig
+++ b/arch/sparc/Kconfig
@@ -64,7 +64,7 @@ config SPARC64
select HAVE_FUNCTION_GRAPH_TRACER
select HAVE_KRETPROBES
select HAVE_KPROBES
- select MMU_GATHER_RCU_TABLE_FREE
+ select MMU_GATHER_RCU_TABLE_FREE if SMP
select HAVE_MEMBLOCK_NODE_MAP
select HAVE_ARCH_TRANSPARENT_HUGEPAGE
select HAVE_DYNAMIC_FTRACE
We should handle that drop of SMP in a separate patch if needed.
-aneesh
next prev parent reply other threads:[~2020-01-18 5:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 6:45 [PATCH v4 0/9] Fixup page directory freeing Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 1/9] powerpc/mmu_gather: Enable RCU_TABLE_FREE even for !SMP case Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-18 11:01 ` Michael Ellerman
2020-01-18 11:01 ` Michael Ellerman
2020-01-18 11:01 ` Michael Ellerman
2020-01-18 11:01 ` Michael Ellerman
2020-01-16 6:45 ` [PATCH v4 2/9] mm/mmu_gather: Invalidate TLB correctly on batch allocation failure and flush Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-18 11:04 ` Michael Ellerman
2020-01-18 11:04 ` Michael Ellerman
2020-01-18 11:04 ` Michael Ellerman
2020-01-18 11:04 ` Michael Ellerman
2020-01-16 6:45 ` [PATCH v4 3/9] asm-generic/tlb: Avoid potential double flush Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:49 ` Aneesh Kumar K.V
2020-01-16 6:49 ` Aneesh Kumar K.V
2020-01-17 1:46 ` Andrew Morton
2020-01-17 1:46 ` Andrew Morton
2020-01-16 6:45 ` [PATCH v4 4/9] asm-gemeric/tlb: Remove stray function declarations Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 5/9] asm-generic/tlb: Add missing CONFIG symbol Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 6/9] asm-generic/tlb: Rename HAVE_RCU_TABLE_FREE Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-17 23:36 ` kbuild test robot
2020-01-18 5:56 ` Aneesh Kumar K.V [this message]
2020-01-18 5:56 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 7/9] asm-generic/tlb: Rename HAVE_MMU_GATHER_PAGE_SIZE Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 8/9] asm-generic/tlb: Rename HAVE_MMU_GATHER_NO_GATHER Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` [PATCH v4 9/9] asm-generic/tlb: Provide MMU_GATHER_TABLE_FREE Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
2020-01-16 6:45 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9p9mhnr.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.