All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/tgl: allow DVI/HDMI on port A
Date: Thu, 14 Nov 2019 14:43:17 +0200	[thread overview]
Message-ID: <87v9rm1vdm.fsf@intel.com> (raw)
In-Reply-To: <20191113021935.41547-1-lucas.demarchi@intel.com>

On Tue, 12 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Tiger Lake supports HDMI on port A. For other platforms we ignore what the VBT
> says regarding HDMI to workaround broken VBTs, see commit
> 2ba7d7e04371 ("drm/i915/bios: ignore HDMI on port A"). Make this apply
> gen12+ so they inherit the TGL behavior.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Do *NOT* merge patches without full IGT results. BAT is *NOT* enough,
and this did not even pass BAT.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 7c0ca733bef8..e6da98729e1f 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1450,7 +1450,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>  	is_hdmi = is_dvi && (child->device_type & DEVICE_TYPE_NOT_HDMI_OUTPUT) == 0;
>  	is_edp = is_dp && (child->device_type & DEVICE_TYPE_INTERNAL_CONNECTOR);
>  
> -	if (port == PORT_A && is_dvi) {
> +	if (port == PORT_A && is_dvi && INTEL_GEN(dev_priv) < 12) {
>  		DRM_DEBUG_KMS("VBT claims port A supports DVI%s, ignoring\n",
>  			      is_hdmi ? "/HDMI" : "");
>  		is_dvi = false;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index ed4a68fb351f..659a03b08849 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -3140,7 +3140,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
>  	DRM_DEBUG_KMS("Adding HDMI connector on [ENCODER:%d:%s]\n",
>  		      intel_encoder->base.base.id, intel_encoder->base.name);
>  
> -	if (WARN_ON(port == PORT_A))
> +	if (INTEL_GEN(dev_priv) < 12 && WARN_ON(port == PORT_A))
>  		return;
>  
>  	if (WARN(intel_dig_port->max_lanes < 4,

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: allow DVI/HDMI on port A
Date: Thu, 14 Nov 2019 14:43:17 +0200	[thread overview]
Message-ID: <87v9rm1vdm.fsf@intel.com> (raw)
Message-ID: <20191114124317.FwS0s_YRxAging23dT4mk6cWFplgilLPXxdKKXy3dIQ@z> (raw)
In-Reply-To: <20191113021935.41547-1-lucas.demarchi@intel.com>

On Tue, 12 Nov 2019, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> Tiger Lake supports HDMI on port A. For other platforms we ignore what the VBT
> says regarding HDMI to workaround broken VBTs, see commit
> 2ba7d7e04371 ("drm/i915/bios: ignore HDMI on port A"). Make this apply
> gen12+ so they inherit the TGL behavior.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Do *NOT* merge patches without full IGT results. BAT is *NOT* enough,
and this did not even pass BAT.

BR,
Jani.


> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 2 +-
>  drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 7c0ca733bef8..e6da98729e1f 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1450,7 +1450,7 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>  	is_hdmi = is_dvi && (child->device_type & DEVICE_TYPE_NOT_HDMI_OUTPUT) == 0;
>  	is_edp = is_dp && (child->device_type & DEVICE_TYPE_INTERNAL_CONNECTOR);
>  
> -	if (port == PORT_A && is_dvi) {
> +	if (port == PORT_A && is_dvi && INTEL_GEN(dev_priv) < 12) {
>  		DRM_DEBUG_KMS("VBT claims port A supports DVI%s, ignoring\n",
>  			      is_hdmi ? "/HDMI" : "");
>  		is_dvi = false;
> diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
> index ed4a68fb351f..659a03b08849 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
> @@ -3140,7 +3140,7 @@ void intel_hdmi_init_connector(struct intel_digital_port *intel_dig_port,
>  	DRM_DEBUG_KMS("Adding HDMI connector on [ENCODER:%d:%s]\n",
>  		      intel_encoder->base.base.id, intel_encoder->base.name);
>  
> -	if (WARN_ON(port == PORT_A))
> +	if (INTEL_GEN(dev_priv) < 12 && WARN_ON(port == PORT_A))
>  		return;
>  
>  	if (WARN(intel_dig_port->max_lanes < 4,

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-11-14 12:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13  2:19 [PATCH] drm/i915/tgl: allow DVI/HDMI on port A Lucas De Marchi
2019-11-13  2:19 ` [Intel-gfx] " Lucas De Marchi
2019-11-13  2:25 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-11-13  2:25   ` [Intel-gfx] " Patchwork
2019-11-13  2:50 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-11-13  2:50   ` [Intel-gfx] " Patchwork
2019-11-13 16:23 ` [PATCH] " Matt Roper
2019-11-13 16:23   ` [Intel-gfx] " Matt Roper
2019-11-14 12:43 ` Jani Nikula [this message]
2019-11-14 12:43   ` Jani Nikula
2019-11-14 17:31   ` Lucas De Marchi
2019-11-14 17:31     ` [Intel-gfx] " Lucas De Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9rm1vdm.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.