From: Kalle Valo <kvalo@codeaurora.org>
To: Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, "David S. Miller" <davem@davemloft.net>,
libertas-dev@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wireless: marvell: add checks for the return value of sysfs_create_group
Date: Tue, 08 Jan 2019 18:46:11 +0200 [thread overview]
Message-ID: <87va2zqer0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181226034305.73411-1-kjlu@umn.edu> (Kangjie Lu's message of "Tue, 25 Dec 2018 21:43:03 -0600")
Kangjie Lu <kjlu@umn.edu> writes:
> sysfs_create_group() could fail, so let's check its return values and
> issue error messages if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
> drivers/net/wireless/marvell/libertas/mesh.c | 4 ++++
The correct prefix is "libertas: ".
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -797,7 +797,11 @@ static void lbs_persist_config_init(struct net_device *dev)
> {
> int ret;
> ret = sysfs_create_group(&(dev->dev.kobj), &boot_opts_group);
> + if (ret)
> + pr_err("failed to create boot_opts_group.\n");
Please add an empty line here for readability and resend the patch as
v2.
> ret = sysfs_create_group(&(dev->dev.kobj), &mesh_ie_group);
> + if (ret)
> + pr_err("failed to create mesh_ie_group.\n");
> }
>
> static void lbs_persist_config_remove(struct net_device *dev)
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Kangjie Lu <kjlu-OJFnDUYgAso@public.gmane.org>
Cc: pakki001-OJFnDUYgAso@public.gmane.org,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] wireless: marvell: add checks for the return value of sysfs_create_group
Date: Tue, 08 Jan 2019 18:46:11 +0200 [thread overview]
Message-ID: <87va2zqer0.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20181226034305.73411-1-kjlu-OJFnDUYgAso@public.gmane.org> (Kangjie Lu's message of "Tue, 25 Dec 2018 21:43:03 -0600")
Kangjie Lu <kjlu-OJFnDUYgAso@public.gmane.org> writes:
> sysfs_create_group() could fail, so let's check its return values and
> issue error messages if it fails.
>
> Signed-off-by: Kangjie Lu <kjlu-OJFnDUYgAso@public.gmane.org>
> ---
> drivers/net/wireless/marvell/libertas/mesh.c | 4 ++++
The correct prefix is "libertas: ".
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
> --- a/drivers/net/wireless/marvell/libertas/mesh.c
> +++ b/drivers/net/wireless/marvell/libertas/mesh.c
> @@ -797,7 +797,11 @@ static void lbs_persist_config_init(struct net_device *dev)
> {
> int ret;
> ret = sysfs_create_group(&(dev->dev.kobj), &boot_opts_group);
> + if (ret)
> + pr_err("failed to create boot_opts_group.\n");
Please add an empty line here for readability and resend the patch as
v2.
> ret = sysfs_create_group(&(dev->dev.kobj), &mesh_ie_group);
> + if (ret)
> + pr_err("failed to create mesh_ie_group.\n");
> }
>
> static void lbs_persist_config_remove(struct net_device *dev)
--
Kalle Valo
next prev parent reply other threads:[~2019-01-08 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 3:43 [PATCH] wireless: marvell: add checks for the return value of sysfs_create_group Kangjie Lu
2019-01-08 16:46 ` Kalle Valo [this message]
2019-01-08 16:46 ` Kalle Valo
2019-01-08 17:42 ` [PATCH v2] libertas: " Kangjie Lu
2019-02-01 12:06 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va2zqer0.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kjlu@umn.edu \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.