* [PATCH] drm/pl111: add of_node_put() @ 2018-11-21 13:17 Yangtao Li 2018-11-28 17:31 ` Eric Anholt 0 siblings, 1 reply; 3+ messages in thread From: Yangtao Li @ 2018-11-21 13:17 UTC (permalink / raw) To: eric, airlied; +Cc: dri-devel, linux-kernel, Yangtao Li of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- drivers/gpu/drm/pl111/pl111_vexpress.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c index 5fa0441bb6df..38c938c9adda 100644 --- a/drivers/gpu/drm/pl111/pl111_vexpress.c +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c @@ -55,6 +55,8 @@ int pl111_vexpress_clcd_init(struct device *dev, } } + of_node_put(root); + /* * If there is a coretile HDLCD and it has a driver, * do not mux the CLCD on the motherboard to the DVI. -- 2.17.0 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/pl111: add of_node_put() 2018-11-21 13:17 [PATCH] drm/pl111: add of_node_put() Yangtao Li @ 2018-11-28 17:31 ` Eric Anholt 0 siblings, 0 replies; 3+ messages in thread From: Eric Anholt @ 2018-11-28 17:31 UTC (permalink / raw) To: airlied; +Cc: dri-devel, linux-kernel, Yangtao Li [-- Attachment #1: Type: text/plain, Size: 344 bytes --] Yangtao Li <tiny.windzz@gmail.com> writes: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. The "bl_idle_init" appeared to be copy-and-paste from some other commit message, so I droppped that bit and pushed. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/pl111: add of_node_put() @ 2018-11-28 17:31 ` Eric Anholt 0 siblings, 0 replies; 3+ messages in thread From: Eric Anholt @ 2018-11-28 17:31 UTC (permalink / raw) To: Yangtao Li, airlied; +Cc: dri-devel, linux-kernel, Yangtao Li [-- Attachment #1: Type: text/plain, Size: 344 bytes --] Yangtao Li <tiny.windzz@gmail.com> writes: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. The "bl_idle_init" appeared to be copy-and-paste from some other commit message, so I droppped that bit and pushed. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-28 17:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-21 13:17 [PATCH] drm/pl111: add of_node_put() Yangtao Li 2018-11-28 17:31 ` Eric Anholt 2018-11-28 17:31 ` Eric Anholt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.