All of lore.kernel.org
 help / color / mirror / Atom feed
* [v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk
  2018-11-08 20:06 ` [PATCH v6 2/3] " Thinh Nguyen
@ 2018-11-14 11:41 ` Felipe Balbi
  -1 siblings, 0 replies; 9+ messages in thread
From: Felipe Balbi @ 2018-11-14 11:41 UTC (permalink / raw)
  To: Thinh Nguyen, linux-usb, devicetree, Rob Herring, Mark Rutland; +Cc: John Youn

Thinh Nguyen <thinh.nguyen@synopsys.com> writes:

> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
> isoc START TRANSFER command failure. However, some affected versions may
> have RTL patches to fix this without a SW workaround. Add this quirk to
> disable the SW workaround when it is not needed.
>
> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
> endpoints.
>
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>

unfortunately, does't apply to testing/next. Could you rebase??

checking file Documentation/devicetree/bindings/usb/dwc3.txt
Hunk #1 FAILED at 37.
1 out of 1 hunk FAILED

(patch 1/3 is applied, though)

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk
  2018-11-14 11:41 ` [PATCH v6 2/3] " Felipe Balbi
@ 2018-11-15  7:00 ` Thinh Nguyen
  -1 siblings, 0 replies; 9+ messages in thread
From: Thinh Nguyen @ 2018-11-15  7:00 UTC (permalink / raw)
  To: Felipe Balbi, Thinh Nguyen, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, Rob Herring, Mark Rutland
  Cc: John Youn

Hi,

On 11/14/2018 3:41 AM, Felipe Balbi wrote:
> Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
>
>> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
>> isoc START TRANSFER command failure. However, some affected versions may
>> have RTL patches to fix this without a SW workaround. Add this quirk to
>> disable the SW workaround when it is not needed.
>>
>> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
>> endpoints.
>>
>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> unfortunately, does't apply to testing/next. Could you rebase??
>
Done.

Thanks,
Thinh

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk
  2018-11-08 20:06 ` [PATCH v6 2/3] " Thinh Nguyen
@ 2018-11-11 22:32 ` Rob Herring
  -1 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2018-11-11 22:32 UTC (permalink / raw)
  To: Thinh Nguyen; +Cc: Felipe Balbi, linux-usb, devicetree, Mark Rutland, John Youn

On Thu, Nov 08, 2018 at 12:06:57PM -0800, Thinh Nguyen wrote:
> DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
> isoc START TRANSFER command failure. However, some affected versions may
> have RTL patches to fix this without a SW workaround. Add this quirk to
> disable the SW workaround when it is not needed.
> 
> Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
> endpoints.
> 
> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> ---
>  Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
>  1 file changed, 3 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 9+ messages in thread
* [v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk
  2018-11-08 20:06 [PATCH v6 0/3] usb: dwc3: Workaround isoc start_transfer failure Thinh Nguyen
@ 2018-11-08 20:06 ` Thinh Nguyen
  -1 siblings, 0 replies; 9+ messages in thread
From: Thinh Nguyen @ 2018-11-08 20:06 UTC (permalink / raw)
  To: Felipe Balbi, linux-usb, devicetree, Rob Herring, Mark Rutland; +Cc: John Youn

DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for
isoc START TRANSFER command failure. However, some affected versions may
have RTL patches to fix this without a SW workaround. Add this quirk to
disable the SW workaround when it is not needed.

Synopsys STAR 9001202023: Wrong microframe number for isochronous IN
endpoints.

Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
---
 Documentation/devicetree/bindings/usb/dwc3.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt
index 636630fb92d7..fc64db0a7a0a 100644
--- a/Documentation/devicetree/bindings/usb/dwc3.txt
+++ b/Documentation/devicetree/bindings/usb/dwc3.txt
@@ -37,6 +37,9 @@ Optional properties:
  - phy-names: from the *Generic PHY* bindings; supported names are "usb2-phy"
 	or "usb3-phy".
  - resets: a single pair of phandle and reset specifier
+ - snps,dis-start-transfer-quirk: when set, disable isoc START TRANSFER command
+			failure SW work-around for DWC_usb31 version 1.70a-ea06
+			and prior.
  - snps,usb3_lpm_capable: determines if platform is USB3 LPM capable
  - snps,disable_scramble_quirk: true when SW should disable data scrambling.
 	Only really useful for FPGA builds.

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [PATCH v6 0/3] usb: dwc3: Workaround isoc start_transfer failure
@ 2018-11-08 20:06 Thinh Nguyen
  0 siblings, 0 replies; 9+ messages in thread
From: Thinh Nguyen @ 2018-11-08 20:06 UTC (permalink / raw)
  To: Felipe Balbi, linux-usb, devicetree, Rob Herring, Mark Rutland; +Cc: John Youn

DWC_usb31 peripheral v1.70a-ea06 and prior needs a SW workaround for isoc START
TRANSFER command failure. This patch series implements that workaround

Change in v6:
 - Defined more version types in "usb: dwc3: Track DWC_usb31 VERSIONTYPE"
 - Minor cleanup/fix in "usb: dwc3: Add workaround for isoc start transfer failure"
Change in v5:
 - Splitted and resent from an old patch series
 - Cleanup and fixed review issues
Change in v4:
 - None
Change in v3:
 - None
Change in v2:
 - None


Thinh Nguyen (3):
  usb: dwc3: Track DWC_usb31 VERSIONTYPE
  usb: dwc3: Add disabling of start_transfer failure quirk
  usb: dwc3: Add workaround for isoc start transfer failure

 Documentation/devicetree/bindings/usb/dwc3.txt |   3 +
 drivers/usb/dwc3/core.c                        |   3 +
 drivers/usb/dwc3/core.h                        |  23 +++++
 drivers/usb/dwc3/gadget.c                      | 131 +++++++++++++++++++++++++
 4 files changed, 160 insertions(+)

-- 
2.11.0

^ permalink raw reply	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-11-15  7:00 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-14 11:41 [v6,2/3] usb: dwc3: Add disabling of start_transfer failure quirk Felipe Balbi
2018-11-14 11:41 ` [PATCH v6 2/3] " Felipe Balbi
  -- strict thread matches above, loose matches on Subject: below --
2018-11-15  7:00 [v6,2/3] " Thinh Nguyen
2018-11-15  7:00 ` [PATCH v6 2/3] " Thinh Nguyen
2018-11-11 22:32 [v6,2/3] " Rob Herring
2018-11-11 22:32 ` [PATCH v6 2/3] " Rob Herring
2018-11-08 20:06 [v6,2/3] " Thinh Nguyen
2018-11-08 20:06 ` [PATCH v6 2/3] " Thinh Nguyen
2018-11-08 20:06 [PATCH v6 0/3] usb: dwc3: Workaround isoc start_transfer failure Thinh Nguyen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.