From: Jani Nikula <jani.nikula@linux.intel.com>
To: Mika Kahola <mika.kahola@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message
Date: Wed, 13 Sep 2017 11:09:31 +0300 [thread overview]
Message-ID: <87vaknj9z8.fsf@nikula.org> (raw)
In-Reply-To: <1504252261-28964-3-git-send-email-mika.kahola@intel.com>
On Fri, 01 Sep 2017, Mika Kahola <mika.kahola@intel.com> wrote:
> Error message indicating that the same MIPI command is sent consecutively
> is perhaps too strongly said. Let's replace that as a debug message instead.
>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Pushed to dinq, thanks for the patch.
BR,
Jani.
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index b48b9b7..e16055d 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -263,7 +263,7 @@ static int dpi_send_cmd(struct intel_dsi *intel_dsi, u32 cmd, bool hs,
>
> /* XXX: old code skips write if control unchanged */
> if (cmd == I915_READ(MIPI_DPI_CONTROL(port)))
> - DRM_ERROR("Same special packet %02x twice in a row.\n", cmd);
> + DRM_DEBUG_KMS("Same special packet %02x twice in a row.\n", cmd);
>
> I915_WRITE(MIPI_DPI_CONTROL(port), cmd);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 7:50 [PATCH 0/2] drm/i915/dsi: Fix error on DSI video mode command Mika Kahola
2017-09-01 7:51 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Mika Kahola
2017-09-01 13:43 ` Ville Syrjälä
2017-09-04 7:59 ` Mika Kahola
2017-09-04 15:04 ` Ville Syrjälä
2017-09-05 8:33 ` Mika Kahola
2017-09-05 9:27 ` Shankar, Uma
2017-09-05 9:44 ` [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command" Vidya Srinivas
2017-09-05 10:43 ` Mika Kahola
2017-09-13 8:05 ` Jani Nikula
2017-09-12 10:02 ` Chauhan, Madhav
2017-09-13 8:09 ` Jani Nikula
2017-09-13 8:13 ` Chauhan, Madhav
2017-09-05 13:16 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Ville Syrjälä
2017-09-05 14:55 ` Shankar, Uma
2017-09-05 15:10 ` Ville Syrjälä
2017-09-01 7:51 ` [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message Mika Kahola
2017-09-13 8:09 ` Jani Nikula [this message]
2017-09-01 8:08 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command Patchwork
2017-09-01 9:34 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-05 9:53 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2) Patchwork
2017-09-05 11:03 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vaknj9z8.fsf@nikula.org \
--to=jani.nikula@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kahola@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.