From: Jani Nikula <jani.nikula@intel.com>
To: "Chauhan, Madhav" <madhav.chauhan@intel.com>,
"Srinivas, Vidya" <vidya.srinivas@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command"
Date: Wed, 13 Sep 2017 11:09:07 +0300 [thread overview]
Message-ID: <87y3pjj9zw.fsf@nikula.org> (raw)
In-Reply-To: <FDE0F82259988449BC0C053E4EF090C96EC80FCD@BGSMSX104.gar.corp.intel.com>
On Tue, 12 Sep 2017, "Chauhan, Madhav" <madhav.chauhan@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of
>> Vidya Srinivas
>> Sent: Tuesday, September 5, 2017 3:15 PM
>> To: intel-gfx@lists.freedesktop.org
>> Cc: Srinivas, Vidya <vidya.srinivas@intel.com>
>> Subject: [Intel-gfx] [PATCH] Revert "drm/i915/bxt: Disable device ready
>> before shutdown command"
>>
>> From: Uma Shankar <uma.shankar@intel.com>
>>
>> This reverts commit bbdf0b2ff32aa75c7bd167569130e9391d2e6282.
>>
>> Disable device ready before shutdown command was added previously to
>> avoid a split screen issue seen on dual link DSI panels. As of now, dual link is
>> not supported and will need some rework in the upstream code. For single
>> link DSI panels, the change is not required. This will cause failure in sending
>> SHUTDOWN packet during disable. Hence reverting the change. Will handle
>> the change as part of dual link enabling in upstream.
>
> Already there are lot of changes wrt to DSI dual link inside intel_dsi.c.
> Can't we keep this change as well under the condition if (dual_link && Broxton)??
> Might help to fetch dual link changes in future instead of losing it.
I've pushed the patch as-is. I don't think there are grounds to keep it
even with dual_link. As Uma says, these things may be panel specific
too.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-13 8:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 7:50 [PATCH 0/2] drm/i915/dsi: Fix error on DSI video mode command Mika Kahola
2017-09-01 7:51 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Mika Kahola
2017-09-01 13:43 ` Ville Syrjälä
2017-09-04 7:59 ` Mika Kahola
2017-09-04 15:04 ` Ville Syrjälä
2017-09-05 8:33 ` Mika Kahola
2017-09-05 9:27 ` Shankar, Uma
2017-09-05 9:44 ` [PATCH] Revert "drm/i915/bxt: Disable device ready before shutdown command" Vidya Srinivas
2017-09-05 10:43 ` Mika Kahola
2017-09-13 8:05 ` Jani Nikula
2017-09-12 10:02 ` Chauhan, Madhav
2017-09-13 8:09 ` Jani Nikula [this message]
2017-09-13 8:13 ` Chauhan, Madhav
2017-09-05 13:16 ` [PATCH 1/2] drm/i915/dsi: Send SHUTDOWN only for v3+ VBT's Ville Syrjälä
2017-09-05 14:55 ` Shankar, Uma
2017-09-05 15:10 ` Ville Syrjälä
2017-09-01 7:51 ` [PATCH 2/2] drm/i915/dsi: Replace MIPI command error message with debug message Mika Kahola
2017-09-13 8:09 ` Jani Nikula
2017-09-01 8:08 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command Patchwork
2017-09-01 9:34 ` ✗ Fi.CI.IGT: warning " Patchwork
2017-09-05 9:53 ` ✓ Fi.CI.BAT: success for drm/i915/dsi: Fix error on DSI video mode command (rev2) Patchwork
2017-09-05 11:03 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3pjj9zw.fsf@nikula.org \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=madhav.chauhan@intel.com \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.