[PATCH maintainer-tools 1/3] make: run check on current `dim`, not the installed one

[PATCH maintainer-tools 1/3] make: run check on current `dim`, not the installed one

[Eric Engestrom]

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b4cea98..4291049 100644
--- a/Makefile
+++ b/Makefile
@@ -33,7 +33,7 @@ shellcheck:
 	shellcheck $(SC_EXCLUDE) dim bash_completion
 
 mancheck:
-	@for cmd in $$(dim list-commands); do \
+	@for cmd in $$(./dim list-commands); do \
 		if ! grep -q "^$$cmd" dim.rst; then \
 			echo "$@: $$cmd not documented"; \
 		fi \
-- 
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH maintainer-tools 2/3] dim: send 'not configured' error to stderr

[Eric Engestrom]

This fixes `make check` when dim is not configured.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 dim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dim b/dim
index 588e859..b373901 100755
--- a/dim
+++ b/dim
@@ -197,7 +197,7 @@ export __dim_running=1
 if [ "$subcommand" != "setup" ] && [ "$subcommand" != "help" ] && [ "$subcommand" != "usage" ]; then
 	for d in $DIM_PREFIX $DIM_PREFIX/$DIM_DRM_INTEL $DIM_PREFIX/drm-rerere $DIM_PREFIX/drm-tip; do
 		if [ ! -d $d ]; then
-			echo "$d is missing, please check your configuration and/or run dim setup"
+			echoerr "$d is missing, please check your configuration and/or run dim setup"
 			exit 1
 		fi
 	done
-- 
Cheers,
  Eric

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions

[Eric Engestrom]

Suggest using git-config instead of a flag on format-patch.
While at it, use the more common "PATCH foo" subject prefix.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 dim.rst | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dim.rst b/dim.rst
index b99248e..c650317 100644
--- a/dim.rst
+++ b/dim.rst
@@ -476,10 +476,11 @@ CONTRIBUTING
 ============
 
 Submit patches for any of the maintainer tools to the
-intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
+intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
 prefix. Use::
 
-  $ git format-patch --subject-prefix="maintainer-tools PATCH"
+  $ git config sendemail.to intel-gfx@lists.freedesktop.org
+  $ git config format.subjectprefix 'PATCH maintainer-tools'
 
 for that. Please make sure your patches pass the build and self tests by
 running::
-- 
Cheers,
  Eric

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions

[Jani Nikula]

On Wed, 05 Apr 2017, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Suggest using git-config instead of a flag on format-patch.
> While at it, use the more common "PATCH foo" subject prefix.

More common? That's all so subjective.

And I've mostly used [dim PATCH]...

BR,
Jani.

>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  dim.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/dim.rst b/dim.rst
> index b99248e..c650317 100644
> --- a/dim.rst
> +++ b/dim.rst
> @@ -476,10 +476,11 @@ CONTRIBUTING
>  ============
>  
>  Submit patches for any of the maintainer tools to the
> -intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
> +intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
>  prefix. Use::
>  
> -  $ git format-patch --subject-prefix="maintainer-tools PATCH"
> +  $ git config sendemail.to intel-gfx@lists.freedesktop.org
> +  $ git config format.subjectprefix 'PATCH maintainer-tools'
>  
>  for that. Please make sure your patches pass the build and self tests by
>  running::

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH maintainer-tools 1/3] make: run check on current `dim`, not the installed one

[Jani Nikula]

On Wed, 05 Apr 2017, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>

For me "current dim" *is* the "installed one". ;)

Pushed patches 1-2.

BR,
Jani.

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index b4cea98..4291049 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -33,7 +33,7 @@ shellcheck:
>  	shellcheck $(SC_EXCLUDE) dim bash_completion
>  
>  mancheck:
> -	@for cmd in $$(dim list-commands); do \
> +	@for cmd in $$(./dim list-commands); do \
>  		if ! grep -q "^$$cmd" dim.rst; then \
>  			echo "$@: $$cmd not documented"; \
>  		fi \

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH maintainer-tools 3/3] dim.rst: update CONTRIBUTING instructions

[Daniel Vetter]

On Wed, Apr 05, 2017 at 12:15:25PM +0100, Eric Engestrom wrote:
> Suggest using git-config instead of a flag on format-patch.
> While at it, use the more common "PATCH foo" subject prefix.
> 
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  dim.rst | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/dim.rst b/dim.rst
> index b99248e..c650317 100644
> --- a/dim.rst
> +++ b/dim.rst
> @@ -476,10 +476,11 @@ CONTRIBUTING
>  ============
>  
>  Submit patches for any of the maintainer tools to the
> -intel-gfx@lists.freedesktop.org mailing list with [maintainer-tools PATCH]
> +intel-gfx@lists.freedesktop.org mailing list with [PATCH maintainer-tools]
>  prefix. Use::
>  
> -  $ git format-patch --subject-prefix="maintainer-tools PATCH"
> +  $ git config sendemail.to intel-gfx@lists.freedesktop.org
> +  $ git config format.subjectprefix 'PATCH maintainer-tools'

With dim this is a worktree checkout, which means all kernel patches end
up looking like this. Can we make this branch-specific?
-Daniel

>  
>  for that. Please make sure your patches pass the build and self tests by
>  running::
> -- 
> Cheers,
>   Eric
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx