From: Felipe Balbi <balbi@kernel.org>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
Manish Narani <manish.narani@xilinx.com>
Cc: gregkh@linuxfoundation.org, xypron.glpk@gmx.de,
mnarani@xilinx.com, bart.vanassche@sandisk.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
anirudh@xilinx.com, svemula@xilinx.com,
target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request
Date: Wed, 22 Mar 2017 11:23:58 +0200 [thread overview]
Message-ID: <87var1u0k1.fsf@linux.intel.com> (raw)
In-Reply-To: <1490080292.8236.99.camel@haakon3.risingtidesystems.com>
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi,
"Nicholas A. Bellinger" <nab@linux-iscsi.org> writes:
> Hi Manish,
>
> (Added target-devel CC')
>
> On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
>> This patch corrects the argument in usb_ep_free_request as it is
>> mistakenly set to ep_out. It should be ep_in for status request.
>>
>> Signed-off-by: Manish Narani <mnarani@xilinx.com>
>> ---
>> drivers/usb/gadget/function/f_tcm.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
>> index d235113..a82e2bd 100644
>> --- a/drivers/usb/gadget/function/f_tcm.c
>> +++ b/drivers/usb/gadget/function/f_tcm.c
>> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>> usb_ep_free_request(fu->ep_out, fu->cmd.req);
>> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
>> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>>
>> kfree(fu->cmd.buf);
>>
>
> Applied to target-pending/master.
Oh, so you're taking patches for f_tcm? Fair enough:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2017-03-22 9:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 9:35 [PATCH] usb: gadget: Correct usb EP argument for BOT status request Manish Narani
2017-03-21 7:11 ` Nicholas A. Bellinger
2017-03-22 9:23 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87var1u0k1.fsf@linux.intel.com \
--to=balbi@kernel.org \
--cc=anirudh@xilinx.com \
--cc=bart.vanassche@sandisk.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=mnarani@xilinx.com \
--cc=nab@linux-iscsi.org \
--cc=svemula@xilinx.com \
--cc=target-devel@vger.kernel.org \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.