* [PATCH] usb: gadget: Correct usb EP argument for BOT status request
@ 2017-03-20 9:35 Manish Narani
2017-03-21 7:11 ` Nicholas A. Bellinger
0 siblings, 1 reply; 3+ messages in thread
From: Manish Narani @ 2017-03-20 9:35 UTC (permalink / raw)
To: balbi, gregkh, nab, xypron.glpk, mnarani, bart.vanassche,
linux-usb, linux-kernel
Cc: anirudh, svemula
This patch corrects the argument in usb_ep_free_request as it is
mistakenly set to ep_out. It should be ep_in for status request.
Signed-off-by: Manish Narani <mnarani@xilinx.com>
---
drivers/usb/gadget/function/f_tcm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index d235113..a82e2bd 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
usb_ep_free_request(fu->ep_in, fu->bot_req_in);
usb_ep_free_request(fu->ep_out, fu->bot_req_out);
usb_ep_free_request(fu->ep_out, fu->cmd.req);
- usb_ep_free_request(fu->ep_out, fu->bot_status.req);
+ usb_ep_free_request(fu->ep_in, fu->bot_status.req);
kfree(fu->cmd.buf);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request
2017-03-20 9:35 [PATCH] usb: gadget: Correct usb EP argument for BOT status request Manish Narani
@ 2017-03-21 7:11 ` Nicholas A. Bellinger
2017-03-22 9:23 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas A. Bellinger @ 2017-03-21 7:11 UTC (permalink / raw)
To: Manish Narani
Cc: balbi, gregkh, xypron.glpk, mnarani, bart.vanassche, linux-usb,
linux-kernel, anirudh, svemula, target-devel
Hi Manish,
(Added target-devel CC')
On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
> This patch corrects the argument in usb_ep_free_request as it is
> mistakenly set to ep_out. It should be ep_in for status request.
>
> Signed-off-by: Manish Narani <mnarani@xilinx.com>
> ---
> drivers/usb/gadget/function/f_tcm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
> index d235113..a82e2bd 100644
> --- a/drivers/usb/gadget/function/f_tcm.c
> +++ b/drivers/usb/gadget/function/f_tcm.c
> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
> usb_ep_free_request(fu->ep_out, fu->cmd.req);
> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>
> kfree(fu->cmd.buf);
>
Applied to target-pending/master.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] usb: gadget: Correct usb EP argument for BOT status request
2017-03-21 7:11 ` Nicholas A. Bellinger
@ 2017-03-22 9:23 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2017-03-22 9:23 UTC (permalink / raw)
To: Nicholas A. Bellinger, Manish Narani
Cc: gregkh, xypron.glpk, mnarani, bart.vanassche, linux-usb,
linux-kernel, anirudh, svemula, target-devel
[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]
Hi,
"Nicholas A. Bellinger" <nab@linux-iscsi.org> writes:
> Hi Manish,
>
> (Added target-devel CC')
>
> On Mon, 2017-03-20 at 15:05 +0530, Manish Narani wrote:
>> This patch corrects the argument in usb_ep_free_request as it is
>> mistakenly set to ep_out. It should be ep_in for status request.
>>
>> Signed-off-by: Manish Narani <mnarani@xilinx.com>
>> ---
>> drivers/usb/gadget/function/f_tcm.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
>> index d235113..a82e2bd 100644
>> --- a/drivers/usb/gadget/function/f_tcm.c
>> +++ b/drivers/usb/gadget/function/f_tcm.c
>> @@ -373,7 +373,7 @@ static void bot_cleanup_old_alt(struct f_uas *fu)
>> usb_ep_free_request(fu->ep_in, fu->bot_req_in);
>> usb_ep_free_request(fu->ep_out, fu->bot_req_out);
>> usb_ep_free_request(fu->ep_out, fu->cmd.req);
>> - usb_ep_free_request(fu->ep_out, fu->bot_status.req);
>> + usb_ep_free_request(fu->ep_in, fu->bot_status.req);
>>
>> kfree(fu->cmd.buf);
>>
>
> Applied to target-pending/master.
Oh, so you're taking patches for f_tcm? Fair enough:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-22 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-20 9:35 [PATCH] usb: gadget: Correct usb EP argument for BOT status request Manish Narani
2017-03-21 7:11 ` Nicholas A. Bellinger
2017-03-22 9:23 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.