* [PATCH] drm: Fix up markup fumble
@ 2016-05-04 13:42 Daniel Vetter
2016-05-04 14:18 ` Jani Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Vetter @ 2016-05-04 13:42 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
It's & for struct references, not #.
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
include/drm/drm_modeset_helper_vtables.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
index b61c2d45192e..d4619dc2eecb 100644
--- a/include/drm/drm_modeset_helper_vtables.h
+++ b/include/drm/drm_modeset_helper_vtables.h
@@ -672,7 +672,7 @@ struct drm_connector_helper_funcs {
* fixed panel can also manually add specific modes using
* drm_mode_probed_add(). Drivers which manually add modes should also
* make sure that the @display_info, @width_mm and @height_mm fields of the
- * struct #drm_connector are filled in.
+ * struct &drm_connector are filled in.
*
* Virtual drivers that just want some standard VESA mode with a given
* resolution can call drm_add_modes_noedid(), and mark the preferred
--
2.8.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm: Fix up markup fumble
2016-05-04 13:42 [PATCH] drm: Fix up markup fumble Daniel Vetter
@ 2016-05-04 14:18 ` Jani Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jani Nikula @ 2016-05-04 14:18 UTC (permalink / raw)
To: DRI Development; +Cc: Daniel Vetter, Daniel Vetter
On Wed, 04 May 2016, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> It's & for struct references, not #.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> include/drm/drm_modeset_helper_vtables.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_modeset_helper_vtables.h b/include/drm/drm_modeset_helper_vtables.h
> index b61c2d45192e..d4619dc2eecb 100644
> --- a/include/drm/drm_modeset_helper_vtables.h
> +++ b/include/drm/drm_modeset_helper_vtables.h
> @@ -672,7 +672,7 @@ struct drm_connector_helper_funcs {
> * fixed panel can also manually add specific modes using
> * drm_mode_probed_add(). Drivers which manually add modes should also
> * make sure that the @display_info, @width_mm and @height_mm fields of the
> - * struct #drm_connector are filled in.
> + * struct &drm_connector are filled in.
This is all right, but in the future I think we should promote "&struct
foo" over "struct &foo". Both work now, but the former makes support for
&enum foo and &union foo nicer in kernel-doc.
BR,
Jani.
> *
> * Virtual drivers that just want some standard VESA mode with a given
> * resolution can call drm_add_modes_noedid(), and mark the preferred
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-04 14:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 13:42 [PATCH] drm: Fix up markup fumble Daniel Vetter
2016-05-04 14:18 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.