From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"michal.kazior@tieto.com" <michal.kazior@tieto.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [patch v2] ath10k: add some sanity checks
Date: Thu, 14 Apr 2016 14:43:02 +0000 [thread overview]
Message-ID: <87vb3kqmiz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160411081520.GA17911@mwanda> (Dan Carpenter's message of "Mon, 11 Apr 2016 11:15:20 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> Smatch complains that since "ev->peer_id" comes from skb->data that
> means we can't trust it and have to do a bounds check on it to prevent
> an array overflow.
>
> Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
In ath.git pending branch I modified the title to be a bit more unique:
ath10k: add some sanity checks to peer_map_event() functions
> ---
> v2: Add a warning message. There is a checkpatch.pl warning that
> the alignment should match the open parenthesis but I ignored it because
> we're going off the end of the 80 character limit and this way is fine.
In ath10k we have used 90 char limit so I fixed this in the pending
branch. And actually I don't think checkpatch complains about the
message format string length of a logging function like ath10k_warn().
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"michal.kazior@tieto.com" <michal.kazior@tieto.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [patch v2] ath10k: add some sanity checks
Date: Thu, 14 Apr 2016 14:43:02 +0000 [thread overview]
Message-ID: <87vb3kqmiz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160411081520.GA17911@mwanda> (Dan Carpenter's message of "Mon, 11 Apr 2016 11:15:20 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> Smatch complains that since "ev->peer_id" comes from skb->data that
> means we can't trust it and have to do a bounds check on it to prevent
> an array overflow.
>
> Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
In ath.git pending branch I modified the title to be a bit more unique:
ath10k: add some sanity checks to peer_map_event() functions
> ---
> v2: Add a warning message. There is a checkpatch.pl warning that
> the alignment should match the open parenthesis but I ignored it because
> we're going off the end of the 80 character limit and this way is fine.
In ath10k we have used 90 char limit so I fixed this in the pending
branch. And actually I don't think checkpatch complains about the
message format string length of a logging function like ath10k_warn().
--
Kalle Valo
WARNING: multiple messages have this Message-ID (diff)
From: "Valo, Kalle" <kvalo@qca.qualcomm.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "michal.kazior@tieto.com" <michal.kazior@tieto.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [patch v2] ath10k: add some sanity checks
Date: Thu, 14 Apr 2016 14:43:02 +0000 [thread overview]
Message-ID: <87vb3kqmiz.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20160411081520.GA17911@mwanda> (Dan Carpenter's message of "Mon, 11 Apr 2016 11:15:20 +0300")
Dan Carpenter <dan.carpenter@oracle.com> writes:
> Smatch complains that since "ev->peer_id" comes from skb->data that
> means we can't trust it and have to do a bounds check on it to prevent
> an array overflow.
>
> Fixes: 6942726f7f7b ('ath10k: add fast peer_map lookup')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
In ath.git pending branch I modified the title to be a bit more unique:
ath10k: add some sanity checks to peer_map_event() functions
> ---
> v2: Add a warning message. There is a checkpatch.pl warning that
> the alignment should match the open parenthesis but I ignored it because
> we're going off the end of the 80 character limit and this way is fine.
In ath10k we have used 90 char limit so I fixed this in the pending
branch. And actually I don't think checkpatch complains about the
message format string length of a logging function like ath10k_warn().
--
Kalle Valo
next prev parent reply other threads:[~2016-04-14 14:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 7:44 [patch] ath10k: add some sanity checks Dan Carpenter
2016-04-11 7:44 ` Dan Carpenter
2016-04-11 7:44 ` Dan Carpenter
2016-04-11 7:52 ` Michal Kazior
2016-04-11 7:52 ` Michal Kazior
2016-04-11 7:52 ` Michal Kazior
2016-04-11 8:15 ` [patch v2] " Dan Carpenter
2016-04-11 8:15 ` Dan Carpenter
2016-04-11 8:15 ` Dan Carpenter
2016-04-14 14:43 ` Valo, Kalle [this message]
2016-04-14 14:43 ` Valo, Kalle
2016-04-14 14:43 ` Valo, Kalle
2016-04-19 15:47 ` Valo, Kalle
2016-04-19 15:47 ` Valo, Kalle
2016-04-19 15:47 ` Valo, Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb3kqmiz.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.