From: Kalle Valo <kvalo@codeaurora.org>
To: Wei-Ning Huang <wnhuang@chromium.org>
Cc: linux-wireless@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Amitkumar Karwar <akarwar@marvell.com>,
Nishant Sarmukadam <nishants@marvell.com>,
snanda@google.com, netdev@vger.kernel.org
Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call
Date: Tue, 29 Mar 2016 11:37:51 +0300 [thread overview]
Message-ID: <87vb45brxc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1459226840-36287-1-git-send-email-wnhuang@chromium.org> (Wei-Ning Huang's message of "Tue, 29 Mar 2016 12:47:20 +0800")
Wei-Ning Huang <wnhuang@chromium.org> writes:
> "single skb allocation failure" happens when system is under heavy
> memory pressure. Add __GFP_REPEAT to skb allocation call so kernel
> attempts to reclaim pages and retry the allocation.
>
> Signed-off-by: Wei-Ning Huang <wnhuang@chromium.org>
Is this really a proper way to fix the issue? This is the first time I'm
hearing about the flag and there isn't even a single user in
drivers/net. I would like to get confirmation from others that
__GFP_REPEAT is really ok to use in a wireless driver before I can take
this.
--
Kalle Valo
next prev parent reply other threads:[~2016-03-29 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 4:47 [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call Wei-Ning Huang
2016-03-29 4:47 ` Wei-Ning Huang
2016-03-29 5:31 ` James Cameron
2016-03-29 5:31 ` James Cameron
2016-03-29 8:37 ` Kalle Valo [this message]
2016-03-29 9:27 ` Wei-Ning Huang
2016-03-29 10:51 ` Amitkumar Karwar
2016-03-29 10:51 ` Amitkumar Karwar
2016-03-29 10:51 ` Amitkumar Karwar
2016-03-29 12:58 ` Eric Dumazet
2016-04-05 5:48 ` Amitkumar Karwar
2016-04-05 5:48 ` Amitkumar Karwar
2016-04-05 5:48 ` Amitkumar Karwar
2016-04-05 16:05 ` David Laight
2016-04-05 16:05 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb45brxc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akarwar@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nishants@marvell.com \
--cc=snanda@google.com \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.