All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Cameron <quozl@laptop.org>
To: Wei-Ning Huang <wnhuang@chromium.org>
Cc: linux-wireless@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	Amitkumar Karwar <akarwar@marvell.com>,
	Nishant Sarmukadam <nishants@marvell.com>,
	snanda@google.com, kvalo@codeaurora.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call
Date: Tue, 29 Mar 2016 16:31:03 +1100	[thread overview]
Message-ID: <20160329053103.GH32709@us.netrek.org> (raw)
In-Reply-To: <1459226840-36287-1-git-send-email-wnhuang@chromium.org>

On Tue, Mar 29, 2016 at 12:47:20PM +0800, Wei-Ning Huang wrote:
> "single skb allocation failure" happens when system is under heavy
> memory pressure.  Add __GFP_REPEAT to skb allocation call so kernel
> attempts to reclaim pages and retry the allocation.

Oh, that's interesting, we're back to this symptom again.

Nice to see this fix.

Heavy memory pressure on 3.5 caused dev_alloc_skb failure in this
driver.  Tracked at OLPC as #12694.

-- 
James Cameron
http://quozl.netrek.org/

WARNING: multiple messages have this Message-ID (diff)
From: James Cameron <quozl-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>
To: Wei-Ning Huang <wnhuang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Amitkumar Karwar
	<akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	Nishant Sarmukadam
	<nishants-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	snanda-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
	kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call
Date: Tue, 29 Mar 2016 16:31:03 +1100	[thread overview]
Message-ID: <20160329053103.GH32709@us.netrek.org> (raw)
In-Reply-To: <1459226840-36287-1-git-send-email-wnhuang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

On Tue, Mar 29, 2016 at 12:47:20PM +0800, Wei-Ning Huang wrote:
> "single skb allocation failure" happens when system is under heavy
> memory pressure.  Add __GFP_REPEAT to skb allocation call so kernel
> attempts to reclaim pages and retry the allocation.

Oh, that's interesting, we're back to this symptom again.

Nice to see this fix.

Heavy memory pressure on 3.5 caused dev_alloc_skb failure in this
driver.  Tracked at OLPC as #12694.

-- 
James Cameron
http://quozl.netrek.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-03-29  5:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-29  4:47 [PATCH] mwifiex: add __GFP_REPEAT to skb allocation call Wei-Ning Huang
2016-03-29  4:47 ` Wei-Ning Huang
2016-03-29  5:31 ` James Cameron [this message]
2016-03-29  5:31   ` James Cameron
2016-03-29  8:37 ` Kalle Valo
2016-03-29  9:27   ` Wei-Ning Huang
2016-03-29 10:51     ` Amitkumar Karwar
2016-03-29 10:51       ` Amitkumar Karwar
2016-03-29 10:51       ` Amitkumar Karwar
2016-03-29 12:58     ` Eric Dumazet
2016-04-05  5:48       ` Amitkumar Karwar
2016-04-05  5:48         ` Amitkumar Karwar
2016-04-05  5:48         ` Amitkumar Karwar
2016-04-05 16:05         ` David Laight
2016-04-05 16:05           ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160329053103.GH32709@us.netrek.org \
    --to=quozl@laptop.org \
    --cc=akarwar@marvell.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nishants@marvell.com \
    --cc=snanda@google.com \
    --cc=wnhuang@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.