From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries
Date: Tue, 22 Mar 2016 16:39:36 +0100 [thread overview]
Message-ID: <87vb4eo72f.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1458614246-28528-1-git-send-email-peterx@redhat.com> (Peter Xu's message of "Tue, 22 Mar 2016 10:37:26 +0800")
Peter Xu <peterx@redhat.com> writes:
> Here we use one g_strdup_printf() to replace the two stack allocated
> array, considering it's more convenient, safe, and as long as it's
> called rarely only when quorum device opens. This will remove the
> unbound stack warning when compiling with "-Wstack-usage=1000000".
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
I lack the time to take this through my tree before my Easter vacation.
Nominating for qemu-trivial, assuming Luiz doesn't mind.
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com,
qemu-trivial <qemu-trivial@nongnu.org>,
qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries
Date: Tue, 22 Mar 2016 16:39:36 +0100 [thread overview]
Message-ID: <87vb4eo72f.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1458614246-28528-1-git-send-email-peterx@redhat.com> (Peter Xu's message of "Tue, 22 Mar 2016 10:37:26 +0800")
Peter Xu <peterx@redhat.com> writes:
> Here we use one g_strdup_printf() to replace the two stack allocated
> array, considering it's more convenient, safe, and as long as it's
> called rarely only when quorum device opens. This will remove the
> unbound stack warning when compiling with "-Wstack-usage=1000000".
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
I lack the time to take this through my tree before my Easter vacation.
Nominating for qemu-trivial, assuming Luiz doesn't mind.
next prev parent reply other threads:[~2016-03-22 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 2:37 [Qemu-devel] [PATCH v2] qdict: fix unbounded stack warning for qdict_array_entries Peter Xu
2016-03-22 15:39 ` Markus Armbruster [this message]
2016-03-22 15:39 ` Markus Armbruster
2016-05-06 18:39 ` [Qemu-trivial] " Michael Tokarev
2016-05-06 18:39 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb4eo72f.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.