All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support
Date: Tue, 02 Feb 2016 14:36:45 +0100	[thread overview]
Message-ID: <87vb67kzde.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <1453804885-15544-4-git-send-email-kraxel@redhat.com> (Gerd Hoffmann's message of "Tue, 26 Jan 2016 11:41:24 +0100")

Gerd Hoffmann <kraxel@redhat.com> writes:

> This patch marks usb-bot as hot-pluggable device, makes attached
> property settable and turns off auto-attach in case the device
> was hotplugged.
>
> Hot-plugging a usb-bot device with one or more scsi devices can be
> done this way now:
>
>   (1) device-add usb-bot,id=foo
>   (2) device-add scsi-{hd,cd},bus=foo.0,lun=0
>   (2b) optionally add more devices (luns 0 ... 15).
>   (3) qom-set foo.attached = true

This isn't exactly pretty, but it beats no hot plug.

A general solution for hot plugging composite devices could perhaps be
prettier, but I'm not aware of any recent work in the area.  Andreas,
Paolo?

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Assuming we want this because we can't have a general solution now:

Reviewed-by: Markus Armbruster <armbru@redhat.com>

  reply	other threads:[~2016-02-02 13:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 10:41 [Qemu-devel] [PATCH 0/4] usb: hotplug support for usb-bot and usb-uas Gerd Hoffmann
2016-01-26 10:41 ` [Qemu-devel] [PATCH 1/4] usb: make USBDevice->attached bool Gerd Hoffmann
2016-02-02 13:06   ` Markus Armbruster
2016-01-26 10:41 ` [Qemu-devel] [PATCH 2/4] usb: add attached property Gerd Hoffmann
2016-02-02 13:33   ` Markus Armbruster
2016-02-02 14:25     ` Gerd Hoffmann
2016-02-02 15:37       ` Markus Armbruster
2016-01-26 10:41 ` [Qemu-devel] [PATCH 3/4] usb-bot: hotplug support Gerd Hoffmann
2016-02-02 13:36   ` Markus Armbruster [this message]
2016-02-02 18:16     ` Andreas Färber
2016-02-03  7:58       ` Gerd Hoffmann
2016-01-26 10:41 ` [Qemu-devel] [PATCH 4/4] usb-uas: " Gerd Hoffmann
2016-02-02 13:36   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vb67kzde.fsf@blackfin.pond.sub.org \
    --to=armbru@redhat.com \
    --cc=afaerber@suse.de \
    --cc=kraxel@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.