From: Markus Armbruster <armbru@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: christian.liebhardt@arcor.de, mjt@tls.msk.ru,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
christian.liebhardt@keysight.com,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
Date: Tue, 19 Jan 2016 08:19:49 +0100 [thread overview]
Message-ID: <87vb6qdoiy.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <9aab0156c2f307ece61c3d8106450d736553a0d5.1453141118.git.alistair.francis@xilinx.com> (Alistair Francis's message of "Mon, 18 Jan 2016 10:42:01 -0800")
Copying maintainer. Always do that even for trivial patches.
Alistair Francis <alistair.francis@xilinx.com> writes:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
>
> Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> include/qom/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 4509166..2848f5e 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to an integer, or NULL if
> + * Returns: the value of the property, converted to an integer, or negative if
> * an error occurs (including when the property value is not an integer).
> */
> int64_t object_property_get_int(Object *obj, const char *name,
WARNING: multiple messages have this Message-ID (diff)
From: Markus Armbruster <armbru@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: christian.liebhardt@arcor.de, mjt@tls.msk.ru,
qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
christian.liebhardt@keysight.com,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description
Date: Tue, 19 Jan 2016 08:19:49 +0100 [thread overview]
Message-ID: <87vb6qdoiy.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <9aab0156c2f307ece61c3d8106450d736553a0d5.1453141118.git.alistair.francis@xilinx.com> (Alistair Francis's message of "Mon, 18 Jan 2016 10:42:01 -0800")
Copying maintainer. Always do that even for trivial patches.
Alistair Francis <alistair.francis@xilinx.com> writes:
> The description of object_property_get_int() stated that on an error
> it returns NULL. This is not the case and the function will return -1
> if an error occurs. Update the commented documentation accordingly.
>
> Reported-By: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Christian Liebhardt <christian.liebhardt@keysight.com>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> ---
> include/qom/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 4509166..2848f5e 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1107,7 +1107,7 @@ void object_property_set_int(Object *obj, int64_t value,
> * @name: the name of the property
> * @errp: returns an error if this function fails
> *
> - * Returns: the value of the property, converted to an integer, or NULL if
> + * Returns: the value of the property, converted to an integer, or negative if
> * an error occurs (including when the property value is not an integer).
> */
> int64_t object_property_get_int(Object *obj, const char *name,
next prev parent reply other threads:[~2016-01-19 7:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 18:42 [Qemu-trivial] [PATCH v1 1/1] qom: Correct object_property_get_int() description Alistair Francis
2016-01-18 18:42 ` [Qemu-devel] " Alistair Francis
2016-01-19 7:19 ` Markus Armbruster [this message]
2016-01-19 7:19 ` Markus Armbruster
2016-01-30 9:35 ` [Qemu-trivial] " Michael Tokarev
2016-01-30 9:35 ` [Qemu-devel] " Michael Tokarev
2016-02-01 23:27 ` [Qemu-trivial] " Alistair Francis
2016-02-01 23:27 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb6qdoiy.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=afaerber@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=christian.liebhardt@arcor.de \
--cc=christian.liebhardt@keysight.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.