From: Markus Armbruster <armbru@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>
Subject: Re: [Qemu-devel] question: about exec/poison.h
Date: Mon, 30 Nov 2015 10:28:08 +0100 [thread overview]
Message-ID: <87vb8jbzvb.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <565C12EA.5090801@redhat.com> (Paolo Bonzini's message of "Mon, 30 Nov 2015 10:12:10 +0100")
Paolo Bonzini <pbonzini@redhat.com> writes:
> On 30/11/2015 04:47, Peter Xu wrote:
>>
>> I met one problem when trying to add a new public function in dump.h
>> named "dump_state_get_global" and using it in hmp.c.
>
> Don't do that. :)
>
> hmp.c functions should in general use the QMP commands as the base. In
> your case, hmp_info_dump should call qmp_query_dump.
Yes. HMP commands need to be implemented on top of QMP commands, to
avoid a feature gap. Exception: HMP commands that make no sense for
QMP, like "print" or "cpu".
next prev parent reply other threads:[~2015-11-30 9:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-30 3:47 [Qemu-devel] question: about exec/poison.h Peter Xu
2015-11-30 8:06 ` Markus Armbruster
2015-11-30 8:46 ` Peter Xu
2015-11-30 9:12 ` Paolo Bonzini
2015-11-30 9:28 ` Markus Armbruster [this message]
2015-11-30 9:48 ` Peter Xu
2015-11-30 9:47 ` Peter Xu
2015-11-30 10:36 ` Paolo Bonzini
2015-11-30 10:45 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb8jbzvb.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.