All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 4/7] ath10k: unify rx undecapping
Date: Mon, 17 Nov 2014 17:11:29 +0200	[thread overview]
Message-ID: <87vbmdoo9q.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=Ws0JGsVBd2J0fe2_JqAhCVpHmNkn10CJx6BCNG-r0cg@mail.gmail.com> (Michal Kazior's message of "Mon, 17 Nov 2014 15:54:23 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 17 November 2014 15:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> This creates a single, common path for MSDU,
>>> A-MSDU and fragmented Rx.
>>>
>>> Hopefully this will make it easier to understand
>>> Rx path and make it easier to work with.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> This patch had few checkpatch warnings. I fixed them with the folded
>> patch and full patch here:
>>
>> https://github.com/kvalo/ath/commit/71fbd07d43e54f5f9f442bc5f2f4f9ef83aead63
>
> Thanks!
>
> [...]
>> @@ -1132,7 +1133,7 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
>>         bool has_fcs_err;
>>         bool has_crypto_err;
>>         bool has_tkip_err;
>> -       bool has_peer_idx_invalid;
>> +       bool has_idx_invalid;
>>         bool is_decrypted;
>
> I don't really like the has_idx_invalid. Perhaps has_peer_err conveys
> a bit more of the original meaning?

What about just peer_idx_invalid? IMHO we really don't need the has_
prefix in that relatively small function.

> As much as I'd like to leave the original var name I'd like to be
> checkpatch warning free. Sigh..

Same here. The checkpatch is just so useful tool to keep the style
unified.

-- 
Kalle Valo

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/7] ath10k: unify rx undecapping
Date: Mon, 17 Nov 2014 17:11:29 +0200	[thread overview]
Message-ID: <87vbmdoo9q.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=Ws0JGsVBd2J0fe2_JqAhCVpHmNkn10CJx6BCNG-r0cg@mail.gmail.com> (Michal Kazior's message of "Mon, 17 Nov 2014 15:54:23 +0100")

Michal Kazior <michal.kazior@tieto.com> writes:

> On 17 November 2014 15:32, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> This creates a single, common path for MSDU,
>>> A-MSDU and fragmented Rx.
>>>
>>> Hopefully this will make it easier to understand
>>> Rx path and make it easier to work with.
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> This patch had few checkpatch warnings. I fixed them with the folded
>> patch and full patch here:
>>
>> https://github.com/kvalo/ath/commit/71fbd07d43e54f5f9f442bc5f2f4f9ef83aead63
>
> Thanks!
>
> [...]
>> @@ -1132,7 +1133,7 @@ static void ath10k_htt_rx_h_mpdu(struct ath10k *ar,
>>         bool has_fcs_err;
>>         bool has_crypto_err;
>>         bool has_tkip_err;
>> -       bool has_peer_idx_invalid;
>> +       bool has_idx_invalid;
>>         bool is_decrypted;
>
> I don't really like the has_idx_invalid. Perhaps has_peer_err conveys
> a bit more of the original meaning?

What about just peer_idx_invalid? IMHO we really don't need the has_
prefix in that relatively small function.

> As much as I'd like to leave the original var name I'd like to be
> checkpatch warning free. Sigh..

Same here. The checkpatch is just so useful tool to keep the style
unified.

-- 
Kalle Valo

  reply	other threads:[~2014-11-17 15:11 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 14:22 [PATCH 0/7] ath10k: rework rx path Michal Kazior
2014-11-04 14:22 ` Michal Kazior
2014-11-04 14:22 ` [PATCH 1/7] ath10k: start using sk_buff_head Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-04 14:22 ` [PATCH 2/7] ath10k: simplify Rx loop Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-04 14:22 ` [PATCH 3/7] ath10k: refactor htt->rx_confused Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-04 14:22 ` [PATCH 4/7] ath10k: unify rx undecapping Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-17 14:32   ` Kalle Valo
2014-11-17 14:32     ` Kalle Valo
2014-11-17 14:54     ` Michal Kazior
2014-11-17 14:54       ` Michal Kazior
2014-11-17 15:11       ` Kalle Valo [this message]
2014-11-17 15:11         ` Kalle Valo
2014-11-18  6:46         ` Michal Kazior
2014-11-18  6:46           ` Michal Kazior
2014-11-18 13:58           ` Kalle Valo
2014-11-18 13:58             ` Kalle Valo
2014-11-04 14:22 ` [PATCH 5/7] ath10k: remove unused function argument Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-04 14:22 ` [PATCH 6/7] ath10k: use rx descriptor for ppdu status extraction Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-17 14:33   ` Kalle Valo
2014-11-17 14:33     ` Kalle Valo
2014-11-04 14:22 ` [PATCH 7/7] ath10k: report rx rate and signal for fragmented Rx Michal Kazior
2014-11-04 14:22   ` Michal Kazior
2014-11-21 17:01 ` [PATCH 0/7] ath10k: rework rx path Kalle Valo
2014-11-21 17:01   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vbmdoo9q.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.